Skip to content

Fix Boom tests#588

Open
thomasculino wants to merge 9 commits into
fritz-marshal:mainfrom
thomasculino:fix-test-frontend-boom
Open

Fix Boom tests#588
thomasculino wants to merge 9 commits into
fritz-marshal:mainfrom
thomasculino:fix-test-frontend-boom

Conversation

@thomasculino

Copy link
Copy Markdown
Collaborator

The skyportal submodule bump pulled in the RTK Query migration, which removed fetchSource, checkSource, and fetchSources as dispatchable thunks from ducks/source.ts / ducks/sources.ts. The BOOM Alert.tsx and SaveAlertButton.tsx still imported and called them, so the Alert component crashed on mount with a TypeError — rendering nothing, causing all frontend test assertions to time out.

Fix: Replace the three removed thunk imports with their RTK Query equivalents (useLazyGetSourceQuery, useLazyCheckSourceQuery, useLazyFetchSourcesQuery) and update the call sites in Alert.tsx and SaveAlertButton.tsx to use the lazy hook trigger pattern instead of dispatch.

@thomasculino thomasculino requested review from mcoughlin and removed request for mcoughlin June 9, 2026 15:51
@mcoughlin mcoughlin self-requested a review June 9, 2026 16:05

@mcoughlin mcoughlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green!

@thomasculino thomasculino force-pushed the fix-test-frontend-boom branch from 6145d46 to 482406d Compare June 9, 2026 17:58
@thomasculino

Copy link
Copy Markdown
Collaborator Author

I'm confused as to why the tests are not passing. Do you have any idea @mcoughlin?

@mcoughlin

Copy link
Copy Markdown
Contributor

@thomasculino I think we should merge RTK Query and then fix these.

@thomasculino

Copy link
Copy Markdown
Collaborator Author

@mcoughlin You mean deploying Fritz with the RTK Query PR? If so, I'm updating files from the extensions folder that were modified by that PR and then we can go ahead and deploy

@mcoughlin

Copy link
Copy Markdown
Contributor

No I mean merging skyportal/skyportal#6209 (Antoine is working through it) and then fixing this.

@thomasculino

thomasculino commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

I see. Do we know when it will be merged? I'd like to deploy fritz soon. There's too many changes between skyportal and production right now. I couldn't deploy end of last week and I've been trying to fix what was broken in the extensions folder since then.

@mcoughlin

Copy link
Copy Markdown
Contributor

@antoine-le-calloch is actively working on this stuff, I am sure as quick as is reasonable.

@thomasculino

Copy link
Copy Markdown
Collaborator Author

Great, thanks!

@thomasculino thomasculino force-pushed the fix-test-frontend-boom branch from 4e5ec30 to 61d8ceb Compare June 11, 2026 21:29
mcoughlin added a commit that referenced this pull request Jun 12, 2026
Fix BOOM alert pages crashing under RTK Query: read groups/source/sources from query hooks

---------

Co-authored-by: Thomas Culino <thomas.culino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants