Fix Boom tests#588
Conversation
6145d46 to
482406d
Compare
|
I'm confused as to why the tests are not passing. Do you have any idea @mcoughlin? |
|
@thomasculino I think we should merge RTK Query and then fix these. |
|
@mcoughlin You mean deploying Fritz with the RTK Query PR? If so, I'm updating files from the extensions folder that were modified by that PR and then we can go ahead and deploy |
|
No I mean merging skyportal/skyportal#6209 (Antoine is working through it) and then fixing this. |
|
I see. Do we know when it will be merged? I'd like to deploy fritz soon. There's too many changes between skyportal and production right now. I couldn't deploy end of last week and I've been trying to fix what was broken in the extensions folder since then. |
|
@antoine-le-calloch is actively working on this stuff, I am sure as quick as is reasonable. |
|
Great, thanks! |
… Alert and SaveAlertButton components
4e5ec30 to
61d8ceb
Compare
The skyportal submodule bump pulled in the RTK Query migration, which removed fetchSource, checkSource, and fetchSources as dispatchable thunks from ducks/source.ts / ducks/sources.ts. The BOOM Alert.tsx and SaveAlertButton.tsx still imported and called them, so the Alert component crashed on mount with a TypeError — rendering nothing, causing all frontend test assertions to time out.
Fix: Replace the three removed thunk imports with their RTK Query equivalents (useLazyGetSourceQuery, useLazyCheckSourceQuery, useLazyFetchSourcesQuery) and update the call sites in Alert.tsx and SaveAlertButton.tsx to use the lazy hook trigger pattern instead of dispatch.