Feature/all defaults#1
Open
zachar-maximov wants to merge 118 commits into
Open
Conversation
Fix for new way of handling scheme in Symfony 3.0
Fix for new way of handling scheme in Symfony 3.0 (1.x)
…chemes key (FriendsOfSymfony#288) * Fix regression introduced by fix for Symfony 3, check for undefined schemes key * Fix tests and add test for new way of scheme definition * Add additional check in schemes usage * Remove duplicate check in router.js and revert changes to existing tests
Similar RoutesResponse instantiation is done in https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/blob/master/Controller/Controller.php#L97. But without this fix, outputs from controller and command are not equal, when JMSI18nRoutingBundle + `--locale` option are used. Conflicts: Command/DumpCommand.php
Conflicts: Command/DumpCommand.php composer.json
* Update commands.rst (by @DRaineri) * Make comments consistent across documentation
* FriendsOfSymfony#219 dump JSON as a step to WebPack support * FriendsOfSymfony#219 dump JSON as a step to WebPack support * Switch to PHP 5.3 array declaration * FriendsOfSymfony#219 dump JSON as a step to WebPack support * FriendsOfSymfony#219 Adding test (based on existing) for use of --format=json
* Attempting Symfony 4 support * testing beta versions * Removing Symfony 2.3 support and not extending the base RouterDebugCommand RouterDebugCommand became final in Symfony 3.4. But it was only extended for 2.3 support anyways. * Explicitly making public services public ... so that they remain public in Symfony 4.0 * using latest LTS * requested changes * registering commands as services and using DI instead of container * re-allowing Symfony 2.7 and making sure we don't allow PHP version 8 yet ;) * updating last test * trying to test with simple-phpunit * Fix PHPUnit configuration * Revert execute permissions on phpunit command * shortening phpdoc
…t-dir-deprecation Fix root dir deprecation and fix PHP 7.4 deprecation
Gulp 3.x is deprecated and does not work on latest version of node.
Upgrade gulp to version 4
* window.location fallback when baseurl is empty or missing
…fony#371)" (FriendsOfSymfony#374) This reverts commit 3c70635.
* Fixed duplicated port in absolute path on non-standard port * Implemented tests
…fSymfony#391) * Fixed issue with creating absolute instead of relative path * Implemented test
Add support for php 8
Set the branch alias of master to 2.x-dev
The "domains" parameter was being set as the "locale" parameter for the RoutesResponse constructor. This meant that you couldn't dump routes using domains (the debug command worked though)
…mfony#414) * feat: add github actions (replace travis) * feat: add github actions (replace travis) * feat: add github actions (replace travis) * Add JS tests to Github actions * Add return types to fix deprecations * Use SF 5.4 for actions Co-authored-by: Tobias Feijten <tobias@drenso.nl>
Fix docs link & format docs for correct display on Github
Fixed dump using domains
Route expose false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all-features branch with the latest changes from main bundle including PHP 8 support