Add macOS smoke test for install.sh#198
Merged
Merged
Conversation
Adds scripts/smoke_install_macos.sh and a smoke-macos job in install-smoke.yml, running on macos-14 directly (no container runtime available for macOS, unlike the Linux distro matrix) since the macOS path (PR #197) has no CI coverage yet — it installs Homebrew, git, python3, MariaDB, PostgreSQL and Node for real, then asserts bench, the admin venv, node and git are all in place. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Confidence Score: 5/5The change adds a new CI job and shell script; no existing behavior is modified. Both files are additive only. The smoke script correctly handles the detached-HEAD CI limitation, has a proper trap-based cleanup, and its assertions mirror the Linux counterpart. No production code is touched. No files require special attention. Reviews (2): Last reviewed commit: "fix: smoke_install_macos.sh doesn't reso..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ed HEAD actions/checkout@v4 leaves the repo in detached HEAD, so `git rev-parse --abbrev-ref HEAD` returned the literal string "HEAD" rather than a branch, which install.sh would then pass straight to `git clone --branch HEAD` and fail. Snapshot the working tree into a throwaway git repo on a hardcoded "main" branch instead, matching how scripts/smoke_install.sh already handles this for the Linux matrix — this also means uncommitted changes get exercised, not just what's been pushed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tanmoysrt
pushed a commit
to tanmoysrt/bench-cli
that referenced
this pull request
Jul 18, 2026
Add macOS smoke test for install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/smoke_install_macos.sh, which runs install.sh directly on a macOS host and checks that bench, the admin venv, node, git and brew all end up installed.smoke-macosjob toinstall-smoke.yml, running onmacos-14.This gives the macOS install path (#197) CI coverage for the first time.
Test plan
shellcheck scripts/smoke_install_macos.shshellcheck -s sh install.shsmoke-macosjob passes onmacos-14