refactor!: remove hierarchy charts#35709
Merged
ruchamahabal merged 2 commits intoJun 15, 2023
Merged
Conversation
- was used for hierarchy charts (org charts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hierarchy charts were added as generic classes to visualize hierarchies for Org Charts: #26261
During the HR app separation, it was still kept in ERPNext as its generic enough for any hierarchy. But currently it's not being used anywhere and we don't see any usage for it in the near future within ERPNext. Plus it will be easier to maintain in HR if all the related code is together.
So moving this to the HRMS app: frappe/hrms#597
Also removing the
html2canvasdependency added for it.https://github.com/frappe/erpnext/wiki/Migration-Guide-to-ERPNext-nightly-version-(future-v15)-%5BWIP%5D#hierarchy-chart-moved-to-frappe-hr