Skip to content

feat: Added check box to combine items with same BOM#25478

Merged
rohitwaghchaure merged 10 commits into
frappe:version-13-hotfixfrom
noahjacob:prod_plan_feat
Jun 3, 2021
Merged

feat: Added check box to combine items with same BOM#25478
rohitwaghchaure merged 10 commits into
frappe:version-13-hotfixfrom
noahjacob:prod_plan_feat

Conversation

@noahjacob

@noahjacob noahjacob commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

Improvements

  • Added a check box to let user combine items with same BOM, which makes item-wise work order creation possible.
  • Created a reference table to keep track of the combined item's sales order after combined.
  • On submitting work order, work order qty in sales orders are updated using the reference table.
    prod_plan
  • Docs

Comment thread erpnext/manufacturing/doctype/production_plan/production_plan.js Outdated
@noahjacob noahjacob force-pushed the prod_plan_feat branch 3 times, most recently from f2b1fac to 3644927 Compare April 26, 2021 09:02
@ankush ankush added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Apr 26, 2021
@ankush ankush removed the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Apr 26, 2021
@noahjacob noahjacob changed the title feat: Added check box to combine items to make item-wise work order creation. feat: Added check box to combine items with same BOM Apr 26, 2021
Comment thread erpnext/manufacturing/doctype/work_order/work_order.py Outdated
Comment thread erpnext/manufacturing/doctype/work_order/work_order.py Outdated
@nabinhait nabinhait changed the base branch from develop to version-13-hotfix May 3, 2021 16:18
Comment thread erpnext/manufacturing/doctype/production_plan/production_plan.json Outdated
Comment thread erpnext/manufacturing/doctype/work_order/work_order.py Outdated
Comment thread erpnext/manufacturing/doctype/work_order/work_order.py Outdated
Comment thread erpnext/manufacturing/doctype/work_order/work_order.py Outdated
Comment thread erpnext/manufacturing/doctype/production_plan/production_plan.py Outdated
@rohitwaghchaure

Copy link
Copy Markdown
Collaborator

@noahjacob Check sider issue

@noahjacob

Copy link
Copy Markdown
Contributor Author

@noahjacob Check sider issue

@rohitwaghchaure fixed

Comment thread erpnext/manufacturing/doctype/production_plan/production_plan.py Outdated
Comment thread erpnext/manufacturing/doctype/production_plan/production_plan.py Outdated
Comment thread erpnext/manufacturing/doctype/work_order/work_order.py Outdated
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 61.24% when pulling 73e41c0 on noahjacob:prod_plan_feat into 90f7ec8 on frappe:version-13-hotfix.

@rohitwaghchaure rohitwaghchaure merged commit 40b90e5 into frappe:version-13-hotfix Jun 3, 2021
@frappe frappe locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants