You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The status specified in the list view of the Material Request doctype often differs from the one in the form view, in the case of docs that are both partially ordered and partially received. This fix ensures that they'd both be the same.
Please provide enough information so that others can review your pull request:
Explain the details for making this change. What existing problem does the pull request solve?
After this update we have an error in material request
Traceback (most recent call last):
File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
response = frappe.api.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
data = execute_cmd(cmd)
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 54, in search_link
search_widget(doctype, txt.strip(), query, searchfield=searchfield, page_length=page_length, filters=filters, reference_doctype=reference_doctype, ignore_user_permissions=ignore_user_permissions)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 90, in search_widget
raise e
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 80, in search_widget
frappe.response["values"] = frappe.call(query, doctype, txt,
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 223, in validate_and_sanitize_search_inputs
return fn(**kwargs)
File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/queries.py", line 219, in item_query
if filters.get('supplier'):
AttributeError: 'NoneType' object has no attribute 'get'
After this update we have an error in material request
Traceback (most recent call last):
File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
response = frappe.api.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
data = execute_cmd(cmd)
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 54, in search_link
search_widget(doctype, txt.strip(), query, searchfield=searchfield, page_length=page_length, filters=filters, reference_doctype=reference_doctype, ignore_user_permissions=ignore_user_permissions)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 90, in search_widget
raise e
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 80, in search_widget
frappe.response["values"] = frappe.call(query, doctype, txt,
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 223, in validate_and_sanitize_search_inputs
return fn(**kwargs)
File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/queries.py", line 219, in item_query
if filters.get('supplier'):
AttributeError: 'NoneType' object has no attribute 'get'
This is not related to this PR, but will be fixed by #25915
frappe
locked as resolved and limited conversation to collaborators
Mar 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status specified in the list view of the Material Request doctype often differs from the one in the form view, in the case of docs that are both partially ordered and partially received. This fix ensures that they'd both be the same.