Skip to content

fix(Material Request): Make status on list and form view the same#24856

Merged
nextchamp-saqib merged 1 commit into
frappe:version-13-hotfixfrom
GangaManoj:material-request-status-fix
May 25, 2021
Merged

fix(Material Request): Make status on list and form view the same#24856
nextchamp-saqib merged 1 commit into
frappe:version-13-hotfixfrom
GangaManoj:material-request-status-fix

Conversation

@GangaManoj

@GangaManoj GangaManoj commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

The status specified in the list view of the Material Request doctype often differs from the one in the form view, in the case of docs that are both partially ordered and partially received. This fix ensures that they'd both be the same.

Screenshot 2021-03-17 at 10 41 23 PM

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

@nabinhait nabinhait changed the base branch from develop to version-13-hotfix May 3, 2021 17:31
@nextchamp-saqib nextchamp-saqib merged commit 18cfced into frappe:version-13-hotfix May 25, 2021
@sammish

sammish commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

Hello @nabinhait @nextchamp-saqib

After this update we have an error in material request

Traceback (most recent call last):
File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
response = frappe.api.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
data = execute_cmd(cmd)
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 54, in search_link
search_widget(doctype, txt.strip(), query, searchfield=searchfield, page_length=page_length, filters=filters, reference_doctype=reference_doctype, ignore_user_permissions=ignore_user_permissions)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 90, in search_widget
raise e
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 80, in search_widget
frappe.response["values"] = frappe.call(query, doctype, txt,
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 223, in validate_and_sanitize_search_inputs
return fn(**kwargs)
File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/queries.py", line 219, in item_query
if filters.get('supplier'):
AttributeError: 'NoneType' object has no attribute 'get'

image

@ankush

ankush commented Jun 2, 2021

Copy link
Copy Markdown
Member

@sammish which exact version you're on?

@sammish

sammish commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

@ankush

#25922

1 similar comment
@sammish

sammish commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

@ankush

#25922

@nabinhait

Copy link
Copy Markdown
Member

Hello @nabinhait @nextchamp-saqib

After this update we have an error in material request

Traceback (most recent call last):
File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
response = frappe.api.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
data = execute_cmd(cmd)
File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 54, in search_link
search_widget(doctype, txt.strip(), query, searchfield=searchfield, page_length=page_length, filters=filters, reference_doctype=reference_doctype, ignore_user_permissions=ignore_user_permissions)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 90, in search_widget
raise e
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 80, in search_widget
frappe.response["values"] = frappe.call(query, doctype, txt,
File "/home/frappe/frappe-bench/apps/frappe/frappe/init.py", line 1174, in call
return fn(*args, **newargs)
File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/search.py", line 223, in validate_and_sanitize_search_inputs
return fn(**kwargs)
File "/home/frappe/frappe-bench/apps/erpnext/erpnext/controllers/queries.py", line 219, in item_query
if filters.get('supplier'):
AttributeError: 'NoneType' object has no attribute 'get'

image

This is not related to this PR, but will be fixed by #25915

@frappe frappe locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants