feat: bootstrap enrollment for Central and Pilot#116
Open
prathameshkurunkar7 wants to merge 5 commits into
Open
feat: bootstrap enrollment for Central and Pilot#116prathameshkurunkar7 wants to merge 5 commits into
prathameshkurunkar7 wants to merge 5 commits into
Conversation
create_site / deploy_site / site and the guest deploy-site.py thread a single-use `bootstrap_token` (was `central_auth_token`) to the bench, which runs `bench enroll` to mint its own long-lived credential. The durable secret is never injected during provisioning — only a short-lived, single-use one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bench-open no longer re-mints a login via Atlas — Central signs the SID and the bench verifies it against the JWKS — so provision.regenerate_vm_login has no caller left. Remove it and its tests. Site-login (regenerate_site_login) is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Confidence Score: 5/5Safe to merge — the rename is complete and consistent, and no call sites were missed. All central_auth_token references are gone (only a comment remains), the argparse attribute name matches the dataclass field, and the enrollment flow is guarded by the same condition as before. No logic changes beyond the deliberate credential-handoff redesign. No files require special attention. Reviews (4): Last reviewed commit: "refactor: fix pre-commit checks" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(atlas): bootstrap-token enrollment (seed, don't inject, the credential)
Provisioning now hands the bench a short-lived enrollment token instead of the durable credential.
create_site/deploy_site/ guestdeploy-site.pythread a single-usebootstrap_token(wascentral_auth_token); the bench runsbench enrollto mint its own long-lived credential. The durable secret is never written during provisioning.provision.regenerate_vm_login— bench-open no longer re-mints a login via Atlas (Central signs the SID, the bench verifies it against the JWKS). Site-login is unchanged.What's next (separate PR — not in scope here)
Enrollment still rides the post-boot deploy SSH, so this doesn't yet remove the boot wait. Follow-up:
ProvisionRequest.cloud_init, currently unused).bench enrollunit that reads the seed from the canonical path; then drop the SSHbench enrollfromdeploy-site.py.Foundation is already in place on the Pilot side (
bench enroll --seed-file+ canonical-path auto-read);Related PRs - Central Pilot