Add external tx hash to map bridge events to their corresponding transactions#336
Draft
qrilka wants to merge 2 commits into
Draft
Add external tx hash to map bridge events to their corresponding transactions#336qrilka wants to merge 2 commits into
qrilka wants to merge 2 commits into
Conversation
Deploying kolme with
|
| Latest commit: |
e5d3d8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ad70e0b.kolme.pages.dev |
| Branch Preview URL: | https://external-tx-hash.kolme.pages.dev |
snoyberg
requested changes
Jun 17, 2025
snoyberg
approved these changes
Jun 17, 2025
| event: deserializer.load_json()?, | ||
| tx_hash: deserializer.load()?, | ||
| attestations: deserializer.load()?, | ||
| tx_hash: if version >= VERSION_WITH_TX_HASH { |
Member
There was a problem hiding this comment.
Ooh, I like this approach of using consts.
Member
|
@qrilka this is still in draft, is this a change you wanted to push through? |
Contributor
Author
|
@snoyberg the idea of DRAFT here was not to stop six sigma from using backwards-compatible updates if they come as we didn't test version upgrades yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.