Skip to content

Ensure upgrade targets do not expand beyond installed packages#1019

Open
razor-x wants to merge 1 commit into
fosskers:masterfrom
rxfork:ignore-package-base
Open

Ensure upgrade targets do not expand beyond installed packages#1019
razor-x wants to merge 1 commit into
fosskers:masterfrom
rxfork:ignore-package-base

Conversation

@razor-x
Copy link
Copy Markdown
Contributor

@razor-x razor-x commented Mar 21, 2026

Closes #975

Hopefully I understood this correctly:

  1. The initial filtered list should be the allowed package names to upgrade based only on what is installed.
  2. The next two lists are for getting metadata from FAUR. (This is the part I don't fully understand).
  3. Regardless of what happens in step (2), the final list should never contain new package names, so we restrict it to the original set.

Initially, I thought I could just apply the original filter again, but step (2) can still expand to more packages than was is currently installed. If I do just this,

        let names = to_upgrade
            .iter()
            .map(|(old, _)| old.name.as_ref())
            .chain(vcs.iter().map(|p| p.name.as_ref()))
            .filter(|name| env.aur.ignores.contains(*name).not());

        install(fll, &env, Mode::Upgrade, names)?;

then "aura :: AUR packages to upgrade:" shows the ignored package, ttf-ms-win11, while the later "aura :: AUR packages:" will have it filtered out.

Since ignored packaged should not be in "AUR packages to upgrade:" I went with the approach in the PR.

@razor-x
Copy link
Copy Markdown
Contributor Author

razor-x commented Mar 27, 2026

@fosskers or @saifshahriar any feedback on this approach? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignores in Config File Does Not Prevent "Install anyway?" Prompt for Installed AUR Package in Package Base

1 participant