Ensure upgrade targets do not expand beyond installed packages#1019
Open
razor-x wants to merge 1 commit into
Open
Ensure upgrade targets do not expand beyond installed packages#1019razor-x wants to merge 1 commit into
razor-x wants to merge 1 commit into
Conversation
Contributor
Author
|
@fosskers or @saifshahriar any feedback on this approach? 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #975
Hopefully I understood this correctly:
Initially, I thought I could just apply the original filter again, but step (2) can still expand to more packages than was is currently installed. If I do just this,
then "aura :: AUR packages to upgrade:" shows the ignored package,
ttf-ms-win11, while the later "aura :: AUR packages:" will have it filtered out.Since ignored packaged should not be in "AUR packages to upgrade:" I went with the approach in the PR.