fix(deps): bump nodemailer to ^9.0.1 (security)#477
Open
pddivine wants to merge 1 commit into
Open
Conversation
Resolves three high-severity advisories in nodemailer <=9.0.0: - GHSA-p6gq-j5cr-w38f: SMTP command injection via unsanitized envelope.size - CRLF injection via Transport name option (EHLO/HELO) - CRLF injection in List-* header comments Closes forwardemail#476. Breaking changes between v7 and v9 were reviewed; neither affects this library's usage: - v8 renamed error code `NoAuth` to `ENOAUTH` (not referenced here). - v9 enables TLS certificate validation by default when fetching remote content (attachments, OAuth2, proxy CONNECT). This library does not configure those code paths itself; consumers who rely on lax TLS can opt out per request via tls.rejectUnauthorized=false. All 29 ava tests pass and lint is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
nodemailerfrom^7.0.12to^9.0.1to resolve three high-severity advisories affectingnodemailer <= 9.0.0:envelope.sizenameoption (EHLO/HELO)List-*header commentsCloses #476.
Breaking change review (v7 → v9)
Both intermediate major bumps were reviewed against this library's usage of nodemailer (
createTransport+sendMailin index.js) and the test suite:NoAuthrenamed toENOAUTH. Not referenced anywhere in this repo (grep clean inindex.js,test/,examples/).href/pathURLs, OAuth2 token endpoints, HTTP/HTTPS proxyCONNECT) now validate the server's TLS certificate by default. This library does not configure those code paths itself, so the change is transparent here. Downstream consumers who previously relied on lax TLS can opt out per request withtls.rejectUnauthorized=false.Test plan
npm test— lint passes, all 29 ava tests pass on nodemailer 9.0.1npm auditno longer flagsnodemaileras a direct vulnerable dependency