Add interface to cvc5 sygus bindings#39
Merged
Merged
Conversation
greatly increase CPU abuse dummy implementation (all returning TermManager)
Member
|
Hi! Thank you so much for the contribution! I’m glad these bindings were useful for your SyGuS project. Everything looks good to me, and I agree that Assuming the build workflow finishes cleanly, I’m happy to merge this. Thanks again! |
Contributor
Author
|
No worries, happy to contribute. Being able to lean on an existing implementation of the Term/TermManager refcounting stuff was super helpful. Thanks for the quick response, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've been working on a project in OCaml that benefits from an interface to a SyGuS solver. Cvc5 is one of those solvers, and this project seems to be the best set of bindings out there, so the quickest and easiest option for me to get SyGuS support in OCaml was to hack it onto your bindings.
In this PR is a working, basic implementation of exactly as much SyGuS stuff as I needed:
There's a couple other SyGuS-relevant functions here and there that I haven't bothered to add, mostly because I didn't need them. But this is easily enough to get started with Cvc5 SyGuS using these bindings, you can implement the examples from the Cvc5 docs and it all works.
Also, my system complained about the use of
intin those original loops, so I switched it out forsize_t. Since I first wrote these bindings, I see it's been changed forlong unsigned intanyway (in 7d8a1a6), which fixes the compiler error, but AFAIKsize_tis technically a more accurate type anyway, so I left my version in this PR. Happy to revert, up to you.Hopefully someone else can benefit from the SyGuS interface :)