Easier for normal user to build. More readable error info about 4 secret for package. - #200
Open
crazypeace wants to merge 3 commits into
Open
crazypeace wants to merge 3 commits into
crazypeace wants to merge 3 commits into
Conversation
Drops the update-signing keys, the code signing and the Packer step: the artifact is the portable build plus an unsigned installer.
A downstream developer without the packer/alpha/update keys or a codesign certificate builds a personal (unsigned) binary by default; the tag-push release path keeps signing and packing as before. signing=full now fails early and names any empty key secret instead of dying later in Packer.
Both are required by every build - signed or not - so the check runs before the signing branch and names the empty secret, instead of writing a credential file the app cannot run with.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier for normal user to build.
More readable error info about 4 secret for package.
