Implement Storage#upload() request#97
Open
davispuh wants to merge 1 commit into
Open
Conversation
Contributor
|
Can you please fix the linting issue? |
Contributor
Author
|
Now it should be fixed |
Contributor
Author
|
I rebased this and test now passes but coverage step fails. I don't really understand that so maybe you could look into fixing that? |
Contributor
Yes the coverage test failure is known issue and shouldn't affect PR merge. |
Contributor
Author
|
ping? |
tristanrobert
left a comment
Member
There was a problem hiding this comment.
Coverage github action is simply old, you should upgrade it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api2/json/nodes/{node}/storage/{storage}/uploadAPI allows to upload ISO images which can then be used for VM installation.See https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/storage/{storage}/upload
This PR implements this API allowing to