add ImageIdentifier.repository for custom-registry image lookups#7474
Open
dansola wants to merge 1 commit into
Open
add ImageIdentifier.repository for custom-registry image lookups#7474dansola wants to merge 1 commit into
dansola wants to merge 1 commit into
Conversation
Contributor
Author
pingsutw
reviewed
Jun 5, 2026
| // "<account>.dkr.ecr.<region>.amazonaws.com/<repo>" for an image built with a custom registry | ||
| // override (clone(registry=...)). When set, GetImage looks the image up there; when empty, the | ||
| // cluster's default repository is used. | ||
| string repository = 2; |
Member
There was a problem hiding this comment.
nit
Suggested change
| string repository = 2; | |
| string registry = 2; |
Contributor
There was a problem hiding this comment.
Is the idea that we will concat these values to create the final image url to check on?
If that's the case, we do need registry, repo and I'm assuming name already has the version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When a flyte v2 image is built with a custom registry override (
clone(registry=...)), theremote-build cache never hits — every deploy rebuilds an image that's already sitting in ECR.
The reason: the existence check (
ImageService.GetImage) only receives the image name, so thedataplane handler always looks in the cluster's default repository, while the build pushed the
image to a different repo. There's currently no way to tell the backend which repository an
image actually lives in, so it can never find custom-registry images and rebuilds them every time.
This PR adds that missing piece of information to the API. (Internal ref: SE-775.)
What changes were proposed in this pull request?
Adds an optional
repositoryfield toImageIdentifier: