Optimizations and refactoring#83
Open
slgrobotics wants to merge 11 commits into
Open
Conversation
* Minor changes after AI review * WIP: launch files * WIP: launch files * Update bno055_params_i2c.yaml * Update bno055_I2C.launch.py * WIP: launch files * Update bno055.launch.py * Comments added to clarify operation mode * Update bno055.launch.py * WIP: mag publishes zeroes * Update SensorService.py * Update SensorService.py * Clarified "with FMC" vs NDOF_FMC_OFF in comments * Update SensorService.py * Update SensorService.py * Cleanup and comments * Added launch/bno055_raw.launch.py * Update bno055_raw.launch.py * Bumped version to 0.5.1 * Update CHANGELOG.rst * Update SensorService.py * Update SensorService.py * Refactored bno055.py - moved code from main() to class body * non-fusing mode: orientation covarience unknown, calib and grav data not published * Update SensorService.py * parameter 'i2c_addr' changed to INTEGER_ARRAY, e.g. [0x28, 0x29]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are proposed changes based on my testing