Repository navigation
Conversation
Keep the workspace override, five direct production manifests and the installed DOMPurify runtime on 3.4.16. Reproduce the stale override in PRs 333 and 334 and add an installed-version contract to prevent a manifest-only security update. Refresh the lockfile for current devalue, fast-uri, brace-expansion, KaTeX, source-map-js, compression and static docs Next security fixes. Regenerate the DICOM license ledger from the exact installed closure without adding audit exceptions.
7 of 8 tasks
This was referenced Oct 7, 2026
Member
Author
|
Closing as superseded. The 3D input, resource and asset contracts have been checked against the accepted implementation in #350, #360, #361 and #364. Verified on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schemaUrito owned archive Blob URLs.Related issue
Closes #324. Continues #336; includes the dependency consistency patch from #337. No merge or npm release is requested.
Change classification
Verification
pnpm install --frozen-lockfilepnpm build,pnpm type-check,pnpm testpnpm exec vitest run --reporter=dotpnpm --filter @file-viewer/renderer-3d verify:geo3d-browserpnpm verify:renderer-sanitizationpnpm site:build,pnpm verify:github-governance,pnpm verify:dicom-license-ledgerpnpm audit --registry=https://registry.npmjs.org --audit-level lowbash .github/scripts/run-gitleaks.shOn this Mac, Firefox initially failed before opening a page because it could not access its app-data directory. The final three-browser run used the same isolated Firefox binary with a separate test app-data name. No user browser profile or system permission was changed. The initial audit attempt against npmmirror lacked an audit endpoint; the final audit used the official registry.
Sample / fixture evidence
test/geo3d-integration-lifecycle.spec.ts.test/geo3d-archive-boundaries.spec.ts.scripts/verify-geo3d-archive-browser.mjsreproduces an outside schema request before the fix, checks its rejection afterward and parses local schemas in glTF and GLB in Chromium/WebKit, both workspace and cold consumer.scripts/geo3d-metadata.test.mjsand the compiled parser in a real Node Worker.scripts/geo3d-fixture-http.mjs. The original response reflected paths and markup; local reproduction did not observe script execution.packages/renderers/3d/scripts/verify-geo3d-host-browser.mjs.Visual evidence
Local COPC Blob rendered through the public headless API:
Risk and compatibility
renderer-3d/geo3d; 3TZ/archive support.Checklist
Independent verification update — 2026-10-07
Current head:
e39234ea26057ffbaa0a15959ea76d17bdbfdf2d.5e62027cf5382274c26f971ca089dfcdded41421makes expiry explicit, retains ownership assertions, and preserves the strict final disposal assertion. A controlled-clock baseline fails before the fix; the corrected fixture passes even with an hour of simulated insertion delay, while removing actual cleanup still fails.0.35.5override/lock closure and installed-Next runtime assertion. Next remains16.3.6; no production Geo3D behavior or compatibility floor changes in these two commits.