Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation, documentation, tests, and CI configuration are consistent with the stated behavior.
0 open findings
What changed in this PR
Improves failure handling, documents Android build/runtime contracts, and expands automated coverage.
Changes:
- Handles missing native plugin registration in the example.
- Clarifies nullable results, errors, signing scope, and AGP 9 requirements.
- Adds native Android tests and CI execution using Java 21.
| File | Description |
|---|---|
test/android_id_test.dart |
Expands Dart contract tests. |
README.md |
Clarifies usage and build requirements. |
lib/android_id.dart |
Documents the public API contract. |
example/test/android_id_example_test.dart |
Tests missing registration handling. |
example/lib/main.dart |
Displays a registration-specific error. |
example/integration_test/android_id_test.dart |
Corrects integration-test scope. |
example/android/.gitignore |
Ignores Kotlin session state. |
CHANGELOG.md |
Records unreleased changes. |
android/src/test/kotlin/dev/fluttercommunity/android_id/AndroidIdPluginTest.kt |
Adds native plugin tests. |
android/build.gradle |
Configures Robolectric and JUnit 4. |
.github/workflows/flutter_build_example.yml |
Runs native tests with Java 21. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nohli
marked this pull request as draft
October 11, 2026 14:17
nohli
marked this pull request as ready for review
October 11, 2026 14:20
nohli
marked this pull request as draft
October 11, 2026 21:40
nohli
marked this pull request as ready for review
October 12, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves missing-plugin handling in the example and clarifies Android ID behavior and setup.
Changes
Testing