Skip to content

Improve Android ID example error handling and documentation - #134

Open
nohli wants to merge 10 commits into
mainfrom
review/stable-release-readiness
Open

nohli wants to merge 10 commits into
mainfrom
review/stable-release-readiness

Conversation

@nohli

@nohli nohli commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

This improves missing-plugin handling in the example and clarifies Android ID behavior and setup.

Changes

  • Show a clear error when the Android plugin is not registered in the example.
  • Document when the ID can change, nullable results, and lookup errors.
  • Clarify the Flutter 3.47+, Android API 24+, and AGP 9 requirements.
  • Add native lookup and lifecycle regression tests, and update the changelog and example lockfile.

Testing

  • 9 package tests, 2 example tests, and 15 native cases pass.
  • Android example builds and emulator checks pass.
  • Analysis and the publish dry run pass without warnings.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 00:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation, documentation, tests, and CI configuration are consistent with the stated behavior.

0 open findings

What changed in this PR

Improves failure handling, documents Android build/runtime contracts, and expands automated coverage.

Changes:

  • Handles missing native plugin registration in the example.
  • Clarifies nullable results, errors, signing scope, and AGP 9 requirements.
  • Adds native Android tests and CI execution using Java 21.
File Description
test/​android_id_test.dart Expands Dart contract tests.
README.md Clarifies usage and build requirements.
lib/​android_id.dart Documents the public API contract.
example/​test/​android_id_example_test.dart Tests missing registration handling.
example/​lib/​main.dart Displays a registration-specific error.
example/​integration_test/​android_id_test.dart Corrects integration-test scope.
example/​android/​.gitignore Ignores Kotlin session state.
CHANGELOG.md Records unreleased changes.
android/​src/​test/​kotlin/​dev/​fluttercommunity/​android_id/​AndroidIdPluginTest.kt Adds native plugin tests.
android/​build.gradle Configures Robolectric and JUnit 4.
.github/​workflows/​flutter_build_example.yml Runs native tests with Java 21.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation, documentation, tests, CI configuration, and release metadata are consistent and complete.

0 open findings

🧠 Review effort: Balanced

@nohli nohli closed this Oct 10, 2026
@nohli nohli reopened this Oct 10, 2026
@nohli
nohli marked this pull request as draft October 11, 2026 14:17
@nohli nohli changed the title Handle Android ID registration failures and clarify build requirements Prepare 1.0.0 and improve Android ID example error handling Oct 11, 2026
@nohli
nohli marked this pull request as ready for review October 11, 2026 14:20
@nohli
nohli marked this pull request as draft October 11, 2026 21:40
@nohli nohli changed the title Prepare 1.0.0 and improve Android ID example error handling Improve Android ID example error handling and documentation Oct 11, 2026
@nohli
nohli marked this pull request as ready for review October 12, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants