Skip to content

migrate stripe android to kgp 9#2437

Open
remonh87 wants to merge 1 commit into
mainfrom
migrate-to-flutter-kgp
Open

migrate stripe android to kgp 9#2437
remonh87 wants to merge 1 commit into
mainfrom
migrate-to-flutter-kgp

Conversation

@remonh87

@remonh87 remonh87 commented Jun 27, 2026

Copy link
Copy Markdown
Member

keep backwards compatibility

@jonasbark we may need to spend some time totally rewriting the build.gradle to the new DSL but we may need to wait for Stripe to pick on this.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Do all checks pass?
  • Have you developed the feature on the latest stable version of Flutter?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Summary by CodeRabbit

  • Chores
    • Updated the payment SDK to a newer version.
    • Improved Android build compatibility with newer development tools and Kotlin settings.

keep backwards compatibility
@remonh87 remonh87 requested a review from jonasbark June 27, 2026 11:08
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 45cbb18d-0783-4c82-9511-973f628ba5c1

📥 Commits

Reviewing files that changed from the base of the PR and between 7f5463c and 72bceb7.

📒 Files selected for processing (3)
  • example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
  • example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved
  • packages/stripe_android/android/build.gradle

📝 Walkthrough

Walkthrough

Updates both iOS SwiftPM lockfiles to stripe-ios-spm 25.17.0 and adjusts the Android Gradle script to gate kotlin-android on AGP major version while moving the Kotlin JVM target to top-level compiler options.

Changes

iOS SwiftPM pin update

Layer / File(s) Summary
SwiftPM lockfile pin update
example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved, example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved
Both iOS Package.resolved files replace the stripe-ios-spm revision and version with 25.17.0 and a new lockfile hash.

Android Gradle Kotlin configuration

Layer / File(s) Summary
Conditional kotlin-android plugin
packages/stripe_android/android/build.gradle
The build script parses the Android Gradle Plugin major version and applies kotlin-android only when it is below 9.
Kotlin JVM target migration
packages/stripe_android/android/build.gradle
android.kotlinOptions.jvmTarget is removed, and a top-level kotlin.compilerOptions.jvmTarget sets JVM_17.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • jonasbark

Poem

A bunny hopped through build-time snow,
Tweaking pins so packages glow.
One ear up for AGP's guise,
One hop for Kotlin's 17 skies. 🐰
I nibble on bugs and watch them go.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main Android build migration to Kotlin Gradle Plugin 9.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-to-flutter-kgp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant