chore: bump Node to 24 for Vercel deploys and CI#331
Open
tnrdd wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gaston-review[bot]](https://avatars.githubusercontent.com/in/3010035?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gaston Review
Verdict: Approved
Score: ████████░░ 8/10
Pull Request Summary
This PR bumps the Node.js version from 22 to 24 across CI workflows (test-main, test-pr), adds an .nvmrc file for local dev and Vercel builds, and sets engines.node in package.json. All three locations are consistent.
Clean, minimal version bump. All the right places are updated — CI, .nvmrc for Vercel/nvm, and engines in package.json. Node 24 is in Active LTS at this point, so no concerns there. Nothing to block on.
🔍 Reviewed by Gaston
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vercel flagged Node 20.x as deprecated: deployments created on or after 2026-10-01 will fail to build unless the project uses Node 24.x.
Changes
engines.node: "24.x". Vercel reads this and builds with Node 24, which resolves the deprecation from the repo (noenginesfield existed before, so the version was coming purely from the Vercel dashboard setting).node-version22 → 24 intest-pr.ymlandtest-main.ymlso tests run on the same major we deploy on.24to document the version for local dev.Follow-up (dashboard)
engines.nodeoverrides it for the build, but for consistency the Vercel Project Settings → Node.js Version should also be set to 24.x so the dashboard doesn't keep showing the deprecated 20.x.