Remove in-progress transaction banner from voter pages#329
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Gaston Review
Verdict: Approved
Score: ████████░░ 8/10
Pull Request Summary
This PR removes the "in-progress transaction" resume/discard banner from both voter pages (membership overview and group detail). In membership.tsx, the useChunkedTxQueue and useVoterGroupQueueCleanup hooks are also removed since they were only used for that banner. In GroupDetail.tsx, only the banner UI and the showResumeBanner variable are removed — the hooks remain because they're still used for actual queue operations.
Pure deletion PR, no logic changes. All removed code is cleanly excised — no orphaned variables, no unused imports left behind. The underlying hooks remain where they're still needed. Nothing to flag.
🔍 Reviewed by Gaston
What
Removes the page-level "You have an in-progress operation for this council (X of Y transactions submitted)" banner with Resume/Discard from the Flow Council Admin Voters pages.
Transaction progress/status is already surfaced by the Save changes confirmation popup (shows
1/3, 2/3…with a spinner, plus a Retry on failure), so the banner duplicated that and read as clutter. This standardizes on the popup as the single place for transaction counts/status.Changes
GroupDetail.tsx(group-detail / Voters page): removed the warning banner and itsshowResumeBannerflag. The queue, the popup wiring (qForChildren→VoterTable), the error/Retry alert, and the cleanup-error alert are untouched, so the submission flow is unchanged.membership.tsx(groups overview page): the same banner lived here only to power a cross-navigation resume affordance. Removed the banner plus its now-dead supporting code: theuseChunkedTxQueuemount, theuseVoterGroupQueueCleanupcall, thecleanupErroralert, and the two unused imports. The queue hook never auto-resumes on mount, so nothing functional is lost.90 lines deleted, 0 added.
Tradeoff
The banner was also the only UI to recover an operation interrupted by a page reload / navigation (Discard did a DB rollback). With it gone, a reload-interrupted operation isn't resumable from the UI; a fresh save just re-runs idempotently and overwrites the stuck queue. Accepted in favor of the simpler, single-source-of-truth popup.
Verification
pnpm typecheck✅pnpm lint✅ (no warnings/errors)pnpm prettier✅ (both files unchanged)