Skip to content

feat: show launched round contract addresses and default existing FCs to Metadata#328

Open
tnrdd wants to merge 4 commits into
mainfrom
feat/fc-launch-addresses-and-default-step
Open

feat: show launched round contract addresses and default existing FCs to Metadata#328
tnrdd wants to merge 4 commits into
mainfrom
feat/fc-launch-addresses-and-default-step

Conversation

@tnrdd

@tnrdd tnrdd commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Changes

1. Contract addresses on the launch page

Once a round is launched (the launch page opened for an existing council), a new Contract Addresses card shows the relevant contracts as links to the Superfluid Explorer:

  • Flow Council GDA → the distribution pool, linked to …/pools/{address}
  • Super App Splitter → linked to …/accounts/{address} (hidden on networks/councils with no splitter)

The GDA pool address is now requested in the launch page's subgraph query; the splitter address comes from the round metadata via the existing useCouncilMetadata hook. The GDA row shows a spinner until the subgraph indexes the pool.

2. Default to the Metadata step when first opening an existing FC

The "Edit" button on a Flow Council card (the entry point into the admin for an existing FC) routed to the Permissions step. It now opens Metadata (round-metadata), matching the recent dropdown change (#317) for switching between Flow Councils.

Verification

pnpm typecheck, pnpm lint, and pnpm prettier all pass.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
platform Ready Ready Preview, Comment Jun 30, 2026 5:06am

Request Review

@gaston-review gaston-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaston Review

Verdict: Approved

Score: ███████░░░ 7/10

Pull Request Summary

This PR does two things: (1) changes the "Edit" button on Flow Council cards to navigate to round-metadata instead of permissions, and (2) adds a "Contract Addresses" card to the Launch page that displays the GDA distribution pool and optional Super App Splitter addresses as links to the Superfluid Explorer.

Review Summary

🔵 Suggestion — Spinner can spin forever when distributionPool is null
The 'Contract Addresses' card shows a <Spinner> whenever distributionPool is falsy. This covers both the loading state and the case where the query completed but distributionPool is genuinely absent (e.g. a council created but not fully launched). Without checking flowCouncilQueryLoading, there's no way to distinguish these, resulting in an indefinite spinner for some councils.

Clean, focused change. The explorer links are constructed safely, external links use target="_blank" rel="noreferrer", and the data sources are appropriate. The only real concern is the spinner UX when the distribution pool address is genuinely absent rather than still loading — worth fixing but not a blocker.

📌 2 inline comments
🔵 Suggestion: 1 · ⚪ Nitpick: 1


🔍 Reviewed by Gaston

Comment thread src/app/flow-councils/launch/launch.tsx
Comment thread src/app/flow-councils/flow-councils.tsx

@gaston-review gaston-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaston Review

Verdict: Approved

Score: ████████░░ 8/10

Pull Request Summary

This PR changes the Flow Council "Edit" button to navigate to the round-metadata step instead of permissions, and adds a "Contract Addresses" card on the Launch page showing GDA distribution pool and optional Super App Splitter addresses as links to the Superfluid Explorer.

The spinner-forever issue I flagged in my last review is fixed — the code now properly checks flowCouncilQueryLoading and shows "Not available" when the distribution pool is genuinely absent. Explorer links are safely constructed, external links use target="_blank" rel="noreferrer", and the splitter row only renders when the address actually exists. Clean, focused change — good to ship.


🔍 Reviewed by Gaston

@gaston-review gaston-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaston Review

Verdict: Approved

Score: ████████░░ 8/10

Pull Request Summary

This PR changes the Flow Council "Edit" button to navigate to round-metadata instead of permissions, adds a "Contract Addresses" card on the Launch page showing GDA pool and optional Super App Splitter addresses as Superfluid Explorer links, and fixes the e2e auto-connect helper to match the account button by role instead of racing an address-tail regex against the profile name fetch.

The spinner-forever issue I flagged earlier is fixed — loading vs. absent states are properly distinguished. Explorer links are safely constructed, external links are correctly secured with target="_blank" rel="noreferrer", and the e2e fix is a solid improvement over the racy address-tail match. Clean, focused, and ready to ship.


🔍 Reviewed by Gaston

@gaston-review gaston-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaston Review

Verdict: Approved

Score: ███████░░░ 7/10

Pull Request Summary

This PR redirects the Flow Council "Edit" button from permissions to round-metadata, adds a "Contract Addresses" card on the Launch page showing GDA pool and optional Super App Splitter addresses as Superfluid Explorer links, and fixes an e2e race condition by matching the account chip button by role instead of a regex on the address tail.

No new changes since my last approval. The spinner-forever fix is in, explorer links are safely constructed with target="_blank" rel="noreferrer", and the e2e improvement is solid. Ship it.


🔍 Reviewed by Gaston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant