Skip to content

Use target repo labels directly for issue health#14

Merged
markphelps merged 1 commit into
mainfrom
dynamic-issue-health-labels-v2
Jun 23, 2026
Merged

Use target repo labels directly for issue health#14
markphelps merged 1 commit into
mainfrom
dynamic-issue-health-labels-v2

Conversation

@markphelps

Copy link
Copy Markdown
Contributor

Summary

  • Remove hardcoded semantic label candidate mapping from issue-health label application.
  • Apply only labels that the model suggests and that exist in the target repository label list.
  • Update the issue-health skill instructions to choose labels from targetRepoLabels directly.

Test Plan

  • node --test test/*.mjs
  • npx -p typescript tsc --noEmit -p tsconfig.json
  • pnpm build

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: comment

The PR refactors issue-health to only apply repository labels present in targetRepoLabels, removing semantic mapping logic. This matches updated instructions and clarifies how labels are chosen. Please ensure suggestedLabels logic is robust, as all label assignment now relies on it. Other code and tests align with this approach.

lib/issue-health.ts

  • major (L66): The removal of ISSUE_TYPE_LABEL_CANDIDATES and SEMANTIC_LABEL_CANDIDATES eliminates all mappings of generic and domain-specific issue labels (such as 'bug', 'feature', etc.) to actual repository labels. The new approach relies exclusively on 'suggestedLabels' from the workflow, anchored to targetRepoLabels, which can miss proper label assignment if those labels are not present in suggestions. Please confirm that suggestedLabels will always comprehensively cover all relevant issue types from targetRepoLabels, as the file's filtering logic now depends entirely on their accuracy.

test/issue-health.test.mjs

  • minor (L120): Tests have been updated so that only labels present in targetRepoLabels are ever assigned. This is correct per new instructions, but consider adding test coverage for edge cases where no applicable label exists, to ensure filter returns empty as intended.

🤖 Automated review by the Flipt PR review agent.

@markphelps markphelps merged commit 83efa57 into main Jun 23, 2026
1 check passed
@markphelps markphelps deleted the dynamic-issue-health-labels-v2 branch June 23, 2026 00:33
markphelps added a commit that referenced this pull request Jun 23, 2026
* origin/main:
  Use target repo labels directly (#14)
  Add workflow-specific local config directory (#13)
  chore: update gitignore
  Add Issue Health Check agent (#12)
  fix(pr-review): relax hard timeout budget
  Budget PR review effort by PR size (#11)
  feat(pr-review): update existing bot review comment (#10)
  chore: update gitignore
  perf(pr-review): make reviews more decisive to cut runtime and tokens
  refactor: read per-repo overrides from .agents/ instead of .flue/
  feat(models): document Kimi K2.6 on Cloudflare Workers AI (#9)
  feat: brand the review footer as Flipt and link the agents repo
  feat: factor prior PR reviews/comments into the review (avoid repeats, respect decisions) (#8)
  feat: connect the Flipt docs MCP so the reviewer can query the docs (#7)
  docs: reposition README as the Flipt agents fleet (PR Review = first agent) (#6)
  fix: post reviews deterministically from the workflow (not the model) (#5)
  fix: drop setup-node pnpm cache so the action works when consumed cross-repo (#4)
  fix: make the PR review agent run end-to-end (gh token + gpt-5-mini) (#3)
  feat: run on GitHub Models with a free default; clarify AGENTS.md (#1)
  feat: initial commit

# Conflicts:
#	lib/issue-health.ts
#	skills/issue-health/SKILL.md
#	test/issue-health.test.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant