Budget PR review effort by PR size#11
Merged
Merged
Conversation
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
* 'main' of https://github.com/flipt-io/agents: feat(pr-review): update existing bot review comment (#10)
There was a problem hiding this comment.
Verdict: approve
Well-defined PR review budget policies are introduced and enforced, with sound tier rules and deterministic timeout handling. All changes are clear; only tiny nits could further polish minor behavior. No changes required for correctness or clarity.
lib/review-timeout.ts
- nit (L80): In the timeoutReviewResult function, template literals are used to format the duration in seconds, but Math.round(timeoutMs / 1000) will lose milliseconds (e.g., 1599ms rounds down to 1s). For consistency with test/review-timeout.test.mjs (which expects 2s for 1500ms) you may want to consistently round up (Math.ceil()). Minor, discretionary.
workflows/pr-review.ts
- nit (L136): The fallback stats used before reviewStats are fetched (changedFiles: 999, additions: 1000, deletions: 0) are highly conservative, which is intentional, but may lead to over-budgeting if stats fetch fails. Consider annotating the code with rationale or tuning the fallback numbers based on most common PR size range. No action needed unless it's affecting review behavior.
🤖 Automated review by the Flipt PR review agent.
markphelps
added a commit
that referenced
this pull request
Jun 19, 2026
* 'main' of https://github.com/flipt-io/agents: Budget PR review effort by PR size (#11)
markphelps
added a commit
that referenced
this pull request
Jun 23, 2026
* origin/main: Use target repo labels directly (#14) Add workflow-specific local config directory (#13) chore: update gitignore Add Issue Health Check agent (#12) fix(pr-review): relax hard timeout budget Budget PR review effort by PR size (#11) feat(pr-review): update existing bot review comment (#10) chore: update gitignore perf(pr-review): make reviews more decisive to cut runtime and tokens refactor: read per-repo overrides from .agents/ instead of .flue/ feat(models): document Kimi K2.6 on Cloudflare Workers AI (#9) feat: brand the review footer as Flipt and link the agents repo feat: factor prior PR reviews/comments into the review (avoid repeats, respect decisions) (#8) feat: connect the Flipt docs MCP so the reviewer can query the docs (#7) docs: reposition README as the Flipt agents fleet (PR Review = first agent) (#6) fix: post reviews deterministically from the workflow (not the model) (#5) fix: drop setup-node pnpm cache so the action works when consumed cross-repo (#4) fix: make the PR review agent run end-to-end (gh token + gpt-5-mini) (#3) feat: run on GitHub Models with a free default; clarify AGENTS.md (#1) feat: initial commit # Conflicts: # lib/issue-health.ts # skills/issue-health/SKILL.md # test/issue-health.test.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan