Explicitly initialize InterpMotion<S>::reference_p and linear_vel#662
Open
williamjenagility wants to merge 1 commit into
Open
Explicitly initialize InterpMotion<S>::reference_p and linear_vel#662williamjenagility wants to merge 1 commit into
williamjenagility wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently debugged some code where the
InterpMotion<S>::reference_pandlinear_velmember variables were not zero when initialized, though the variables need to be zero (as described by the comments). I've explicitly zeroed these vectors when calling the default constructor which fixed my personal local issue.This change is