Minor code corrections#660
Merged
SeanCurtis-TRI merged 1 commit intoJan 28, 2026
Merged
Conversation
1. Remove unused variable - a counter that never gets read; modern compilers get angry about it. 2. Misuse of std::move -- we should never do "using std::move".
SeanCurtis-TRI
commented
Jan 28, 2026
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
Contributor
Author
There was a problem hiding this comment.
+a:@sherm1 for review, please. Just a bit more weeding.
@SeanCurtis-TRI made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @sherm1).
sherm1
approved these changes
Jan 28, 2026
sherm1
left a comment
sherm1
left a comment
Member
There was a problem hiding this comment.
@sherm1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI).
SeanCurtis-TRI
merged commit ec358d6
into
flexible-collision-library:master
1 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is