Skip to content

Updated nonnegative_int tests to use _n literals #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khoang05 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated nonnegative_int tests to use _n literals #1658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aefb8e
Updated nonnegative_int tests to use _n literals 1 file changed, 60 i…
khoang05 Jun 25, 2026
10126d8
Update lib/utils/test/src/utils/nonnegative_int/nonnegative_int.cc
khoang05 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 61 additions & 63 deletions lib/utils/test/src/utils/nonnegative_int/nonnegative_int.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int == comparisons") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, equal") {
CHECK(nn_int_1a == nn_int_1b);
}
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
CHECK(1_n == 1_n);
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, not equal") {
CHECK_FALSE(nn_int_1a == nn_int_2);
}
Expand All @@ -43,9 +41,9 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int != comparisons") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, equal") {
CHECK_FALSE(nn_int_1a != nn_int_1b);
}
Expand All @@ -67,9 +65,9 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int < comparisons") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, less than") {
CHECK(nn_int_1a < nn_int_2);
}
Expand Down Expand Up @@ -100,9 +98,9 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int <= comparisons") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, less than") {
CHECK(nn_int_1a <= nn_int_2);
}
Expand Down Expand Up @@ -133,9 +131,9 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int > comparisons") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, less than") {
CHECK_FALSE(nn_int_1a > nn_int_2);
}
Expand Down Expand Up @@ -166,9 +164,9 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int >= comparisons") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
SUBCASE("LHS: nonnegative_int, RHS: nonnegative_int, less than") {
CHECK_FALSE(nn_int_1a >= nn_int_2);
}
Expand Down Expand Up @@ -199,124 +197,124 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int::operator+(nonnegative_int)") {
nonnegative_int result = nonnegative_int{1} + nonnegative_int{2};
nonnegative_int correct = nonnegative_int{3};
nonnegative_int result = 1_n + 2_n;
nonnegative_int correct = 3_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator++() (pre-increment)") {
nonnegative_int input = nonnegative_int{1};
nonnegative_int input = 1_n;

nonnegative_int result = ++input;
nonnegative_int correct = nonnegative_int{2};
nonnegative_int correct = 2_n;

CHECK(result == correct);
CHECK(input == correct);
}

TEST_CASE("nonnegative_int::operator++(int) (post-increment)") {
nonnegative_int input = nonnegative_int{1};
nonnegative_int input = 1_n;

nonnegative_int result = input++;
nonnegative_int correct_input = nonnegative_int{2};
nonnegative_int correct_result = nonnegative_int{1};
nonnegative_int correct_input = 2_n;
nonnegative_int correct_result = 1_n;

CHECK(result == correct_result);
CHECK(input == correct_input);
}

TEST_CASE("nonnegative_int::operator+=(nonnegative_int)") {
nonnegative_int result = nonnegative_int{1};
result += nonnegative_int{3};
nonnegative_int result = 1_n;
result += 3_n;

nonnegative_int correct = nonnegative_int{4};
nonnegative_int correct = 4_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator*(nonnegative_int)") {
nonnegative_int result = nonnegative_int{2} * nonnegative_int{3};
nonnegative_int correct = nonnegative_int{6};
nonnegative_int result = 2_n * 3_n;
nonnegative_int correct = 6_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator*=(nonnegative_int)") {
nonnegative_int result = nonnegative_int{3};
result *= nonnegative_int{6};
nonnegative_int result = 3_n;
result *= 6_n;

nonnegative_int correct = nonnegative_int{18};
nonnegative_int correct = 18_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator/(nonnegative_int)") {
nonnegative_int result = nonnegative_int{5} / nonnegative_int{2};
nonnegative_int correct = nonnegative_int{2};
nonnegative_int result = 5_n / 2_n;
nonnegative_int correct = 2_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator/=(nonnegative_int)") {
nonnegative_int result = nonnegative_int{13};
result /= nonnegative_int{3};
nonnegative_int result = 13_n;
result /= 3_n;

nonnegative_int correct = nonnegative_int{4};
nonnegative_int correct = 4_n;

CHECK(result == correct);
}

TEST_CASE("operator/(float, nonnegative_int)") {
float result = 5.0 / nonnegative_int{2};
float result = 5.0 / 2_n;
float correct = 5.0 / 2;

CHECK(result == correct);
}

TEST_CASE("operator/=(float, nonnegative_int)") {
float result = 13.0;
result /= nonnegative_int{3};
result /= 3_n;

float correct = 13.0 / 3;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator/(nonnegative_int)") {
nonnegative_int result = nonnegative_int{5} / nonnegative_int{2};
nonnegative_int correct = nonnegative_int{2};
nonnegative_int result = 5_n / 2_n;
nonnegative_int correct = 2_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator/=(nonnegative_int)") {
nonnegative_int result = nonnegative_int{13};
result /= nonnegative_int{3};
nonnegative_int result = 13_n;
result /= 3_n;

nonnegative_int correct = nonnegative_int{4};
nonnegative_int correct = 4_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator%(nonnegative_int)") {
nonnegative_int result = nonnegative_int{5} % nonnegative_int{2};
nonnegative_int correct = nonnegative_int{1};
nonnegative_int result = 5_n % 2_n;
nonnegative_int correct = 1_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::operator%=(nonnegative_int)") {
nonnegative_int result = nonnegative_int{15};
result %= nonnegative_int{4};
nonnegative_int result = 15_n;
result %= 4_n;

nonnegative_int correct = nonnegative_int{3};
nonnegative_int correct = 3_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative_int::int_from_nonnegative_int()") {
nonnegative_int input = nonnegative_int{3};
nonnegative_int input = 3_n;

int result = input.int_from_nonnegative_int();
int correct = 3;
Expand All @@ -325,7 +323,7 @@ TEST_SUITE(FF_TEST_SUITE) {
}

TEST_CASE("nonnegative_int::size_t_from_nonnegative_int()") {
nonnegative_int input = nonnegative_int{3};
nonnegative_int input = 3_n;

size_t result = input.size_t_from_nonnegative_int();
size_t correct = 3;
Expand All @@ -335,7 +333,7 @@ TEST_SUITE(FF_TEST_SUITE) {

TEST_CASE("adl_serializer<nonnegative_int>") {
SUBCASE("to_json") {
nonnegative_int input = nonnegative_int{5};
nonnegative_int input = 5_n;

nlohmann::json result = input;
nlohmann::json correct = 5;
Expand All @@ -347,16 +345,16 @@ TEST_SUITE(FF_TEST_SUITE) {
nlohmann::json input = 5;

nonnegative_int result = input.template get<nonnegative_int>();
nonnegative_int correct = nonnegative_int{5};
nonnegative_int correct = 5_n;

CHECK(result == correct);
}
}

TEST_CASE("std::hash<nonnegative_int>") {
nonnegative_int nn_int_1a = nonnegative_int{1};
nonnegative_int nn_int_1b = nonnegative_int{1};
nonnegative_int nn_int_2 = nonnegative_int{2};
nonnegative_int nn_int_1a = 1_n;
nonnegative_int nn_int_1b = 1_n;
nonnegative_int nn_int_2 = 2_n;
std::hash<nonnegative_int> hash_fn;
SUBCASE("Identical values have the same hash") {
CHECK(hash_fn(nn_int_1a) == hash_fn(nn_int_1b));
Expand All @@ -376,21 +374,21 @@ TEST_SUITE(FF_TEST_SUITE) {

TEST_CASE("_n suffix") {
nonnegative_int result = 5_n;
nonnegative_int correct = nonnegative_int{5};
nonnegative_int correct = 5_n;

CHECK(result == correct);
}

TEST_CASE("nonnegative int >> operator") {
nonnegative_int nn_int_1 = nonnegative_int{1};
nonnegative_int nn_int_1 = 1_n;
std::ostringstream oss;
oss << nn_int_1;

CHECK(oss.str() == "1");
}

TEST_CASE("fmt::to_string(nonnegative_int)") {
nonnegative_int nn_int_1 = nonnegative_int{1};
nonnegative_int nn_int_1 = 1_n;
CHECK(fmt::to_string(nn_int_1) == "1");
}
}