Skip to content

Switch Legion to master branch and update#1622

Merged
lockshaw merged 3 commits into
flexflow:masterfrom
elliottslaughter:update-legion
Jan 8, 2026
Merged

Switch Legion to master branch and update#1622
lockshaw merged 3 commits into
flexflow:masterfrom
elliottslaughter:update-legion

Conversation

@elliottslaughter

@elliottslaughter elliottslaughter commented Dec 9, 2025

Copy link
Copy Markdown
Collaborator

This is preparation for the various Realm branches, getting Legion up to date to avoid future build complications.

  • Switch Legion from flexflow branch to master
  • Update Legion to latest (as of 2025-01-07)

My understanding is that the contents of Legion's flexflow branch are as follows:

  • Sets cfg_task_streams to 1 by default
    • This can be configured by -ll:streams and no longer requires a branch
  • Customizes the value of LEGION_MAX_RETURN_SIZE
    • No longer required because the FlexFlow backend for Legion is defunct anyway and the future is moving to Realm (for which this setting is irrelevant)

Beyond this, Legion's master branch has at least one critical feature for using Realm moving forward:

  • Newer Realm versions dlopen the library libcuda.so instead of hard linking it, which makes test integration much easier.

Therefore I think Legion's master branch should be sufficient for all purposes moving forward and we should stop tracking a custom branch.


This change is Reviewable

@elliottslaughter
elliottslaughter force-pushed the update-legion branch 7 times, most recently from 4f06179 to 28ecfd2 Compare December 9, 2025 22:22
@lockshaw
lockshaw enabled auto-merge (squash) January 8, 2026 05:09
@lockshaw
lockshaw merged commit 8cc790e into flexflow:master Jan 8, 2026
3 checks passed
@elliottslaughter
elliottslaughter deleted the update-legion branch January 8, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants