update to use wave port#533
Conversation
Spell Check ReportTFLNTidy3d.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
alec-flexcompute
left a comment
There was a problem hiding this comment.
Looks good @FilipeFcp - however I'm not too experienced with Waveport, so I'm interested to hear @mingzhou-flex's feedback
|
Looks good to me. I only have one minor comment for the in-line comments above the definition of WavePort. In general, the size of the port only needs to cover both the signal and ground electrodes plus a bit of space around them where the fields die off, and the boundary has to intersect with some conductors for AutoImpedance to work. Given that, I think it is better to explain the choise of port size, rather than directly set it to sim_vpi.size[1/2]. Setting it to sim_vpi.size[1/2] works here becasue the groun electrodes extend all the way to the boundary of the simulation. |
|
Thanks @mingzhou-flex.
|
|
Yes. |

Hi all. I just updated it to use
WavePort, which simplifies the workflow. @mingzhou-flex, it would be great if you could check the RF part.Note
Low Risk
Documentation/example-only change in a Jupyter notebook; no production code paths, though RF numerics should be validated by an RF reviewer as noted in the PR.
Overview
The TFLN electro-optic modulator example (
TFLNTidy3d.ipynb) replaces the manual RF CPW mode-solver setup withtidy3d.rf.WavePort, aligning the notebook with the microwave RF API.get_sim()now defines a cross-sectionWavePortwithMicrowaveModeSpecandAutoImpedanceSpec, so voltage/current integration paths and characteristic impedance are inferred from conductors on the port plane instead of being configured by hand. The RFModeSimulationis built viawave_port.to_mode_simulation(), and the function returnssim_vpi,mzm_solver, andwave_portfor downstream use and visualization.Narrative and plotting are updated to document
WavePortand overlay the port plane on the CPW cross-section; parameter sweeps still key off the mode solver produced from the port.Reviewed by Cursor Bugbot for commit 1eaf163. Bugbot is set up for automated code reviews on this repo. Configure here.