Skip to content

feat(settings): one settings page with a section rail, labelled checkout rules and a save bar - #127

Closed
roncodes wants to merge 15 commits into
release/v0.4.25from
feat/settings-page
Closed

feat(settings): one settings page with a section rail, labelled checkout rules and a save bar#127
roncodes wants to merge 15 commits into
release/v0.4.25from
feat/settings-page

Conversation

@roncodes

@roncodes roncodes commented Oct 10, 2026

Copy link
Copy Markdown
Member

Summary

Store settings from design board 8b. Stacked on #126; review the top commit.

  • Shell: identity header (logo, store name, public id, currency, timezone, Copy store key) and a section rail: General, Branding and media, Locations, Checkout rules, Payment gateways, Notification channels, Alerts, API keys. General-page sections are anchors (smooth scroll); locations, gateways, notifications and API keep their routes so existing deep links work. Replaces the five-tab TabNavigation.
  • General page rebuilt as always-open sections instead of a 350-line column of collapsed panels: General (name, read-only store key, currency, default order config, description, tags, contact & social folded), Branding and media (logo, backdrop, images & videos), Checkout rules, Alerts.
  • Checkout rules: every rule the server honours is a Storefront::SettingRule row with an icon, a label and its consequence written under it (online, pickup, store tips, delivery tips, minimum order amount, cash on delivery, tax, auto-accept, auto-dispatch, proof of delivery). Detail inputs (amount, tax %, POD method) appear inside the row when the rule is on.
  • Save bar: sticky, shows "N unsaved changes · General · Checkout rules" or "All changes saved", Discard (rolls back attributes, options and alerts to the loaded snapshot) and Save. Options and alerts are plain objects, so the controller snapshots them and bumps a revision on toggle/input to track dirtiness.

Not here: Hours section (hours live with locations), Danger zone (no delete-store action exists today), network settings on the same shell, ember-ui Form::SaveBar extraction.

Related Issue

Storefront UX overhaul, design canvas board 8b.

Type of Change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Test
  • Chore

Implementation Notes

All existing fields and uploads were moved verbatim (contact & social, logo/backdrop, media dropzone, alerts). The form listens to input/change to refresh the dirty state for two-way-bound option inputs.

Validation

  • Tests — not run locally per the maintainer's request.
  • Lint — not run locally (CI).
  • Build — not run locally (CI).
  • Manual validation — maintainer.

Documentation Impact

  • No documentation changes needed
  • Documentation updated in fleetbase/fleetbase.io
  • Documentation needed but not included

API Reference Impact

  • No API reference changes needed
  • Updated fleetbase/postman
  • API reference updates required but not included

Documentation Notes

docs/storefront → settings: the rail, checkout rules and their meaning. needs-docs for the series.

Risk

The SettingsContainer wrapper used by the other settings pages still renders inside the new content column; those pages were not restyled. Save is disabled until something changes.

Screenshots / Recordings

Design canvas board 8b: https://claude.ai/artifact/771ptEFmi4BLmYHBZuUhWF

@roncodes
test: make the engine's own test suite bootable
b89a946 
The dummy app never ran: ember-classic-decorator (unused) crashes on Ember 5,
lazy loading kept the engine's modules out of the test bundle, and the host
services, config and intl data the panels need were missing. Mirrors what
fleetops already does: eager loading when `ember test` runs from this package,
an inert stand-in for the console's extensions module, the API config the
core adapter reads at module scope, and the legacy built-in components the
engine's templates still use.

The dummy intl service ignores missing locale data, since headless Chrome has
no number formats for every bundled locale, and the order details and network
controller tests stub the host router, fetch and app cache the way the widget
tests already do.
@roncodes
feat(food-trucks): networks show their member stores' trucks; a truck…
3c6ad10 
… is only found by its own storefront
@roncodes
feat(cards): catalogs, trucks and networks render on the shared resou…
e60a706 
…rce card

Catalog, truck and network index pages use Layout::Resource::CardsGrid with
one card each on Layout::Resource::Card, following the Fleet-Ops anatomy:
identity and subtitle in the header, media or facts in the body, status,
icon actions and meta in the footer, with registry slots at each end.

A catalog card shows its categories with product counts, its hours as a
seven-day strip (the new Storefront::HoursStrip) and its product total; a
draft is dashed. A truck card is a Vehicle::Pill with the online dot, the
vehicle photo, where it serves, and a presence badge that says serving,
offline, inactive, or online with no catalog. A network card shows the logo on
its backdrop, the online state, the currency and member count.

"Food trucks" reads "Trucks" in the UI; the food-truck model, routes and
permissions keep their names. The catalogs and trucks pages gain the search
the header already offered.
@roncodes
fix(truck-card): the online dot comes from the vehicle; a truck witho…
672665c 
…ut a vehicle renders its placeholder
@roncodes roncodes added needs-docs Requires documentation updates needs-human-review Requires human review before proceeding type:feature Feature or enhancement labels Oct 10, 2026
@roncodes roncodes mentioned this pull request Oct 10, 2026
Closed
4 of 9 tasks
@roncodes
roncodes force-pushed the feat/settings-page branch 2 times, most recently from 6ed6e17 to 658f0e7 Compare October 10, 2026 08:16
@roncodes
fix(truck): a model attribute named store shadowed Ember Data's store…
4900d9e 
… and crashed createRecord; the store summary is store_summary
@roncodes
feat(context): the console is scoped to a store or a network, with it…
b409f73 
…s own sidebar for each

- storefront service tracks a network context derived from the network route
- StoreSelector becomes the context switcher with a Networks group and create-network
- application route loads networks; sidebar rewrites for the network context
- network page is a full page with an identity strip; the list hides while one is open
- new Trucks section for a network backed by FoodTruckFilter::network
- network orders and customers are scoped to the network being viewed, not the active store
- createNewNetwork lives on the storefront service
@roncodes
fix(switcher): the context switcher the design shows, and the store m…
41506ec 
…enu without Networks

- trigger: context icon, name, STORE/NETWORK label and caret; blue for a store, indigo for a network; invitation badge
- menu: Stores and Networks groups with tiles, currency or member count, a check on the active one, readable in dark mode; footer actions read New store / New network
- store navigation follows the design order (Dashboard, Orders, Products, Catalogs, Customers, Trucks, Promotions, Settings); networks live in the switcher, not the menu
- network page loses the All networks button; leaving a network is the switcher's job
@roncodes
fix(switcher): expose the active context through native getters so th…
56b5f95 
…e sidebar re-renders on a switch; networks report their store count
@roncodes
feat(network): overview, stores with status tabs and bulk actions, an…
f535fdc 
…d an invite panel

- network index is now an Overview (stat tiles, members with 7-day share, invitations, recent orders); settings move to networks.index.network.settings
- NetworkController gains overview, invitations, resend and revoke; one Invite per recipient carrying category, expiry, message and approval in meta
- OrderFilter/CustomerFilter gain a network filter on meta.storefront_network_id; the network orders and customers routes use it
- Storefront::Network::InvitePanel (by email, shareable link, add a store you manage) replaces the share-network and add-stores modals
- stores page: store identity column via a new store descriptor, All/Online/Offline/Invited tabs, bulk assign category and remove, invitation rows with resend/revoke/invite again
- store and network resource descriptors registered with the shared identity registry; SelectOption::Store wrapper; width-style helper
@roncodes
fix(i18n): drop the duplicate common.store key that broke the transla…
f4b6dbb 
…tion build
@roncodes
fix(engine): the descriptor initializer runs inside the engine; its h…
184b5e3 
…ost re-export broke console boot before the lazy engine loaded
@roncodes
feat(network-orders): orders grouped by checkout with status tabs, st…
7182093 
…ore stacks and next actions

- a multi-store checkout is one expandable row (customer, stores, fulfillment, total with tip split, shared driver, least-advanced status) that opens into each store's order
- status tabs (needs action, preparing, ready for pickup, out for delivery, completed, canceled) drive the status query param; grouped/flat toggle
- new cells: reference, stores (identity stack of store pills), fulfillment, total, driver (inline assign), status, placed, actions (next action promoted, rest behind an ellipsis)
- order index resource keeps meta.checkout_id so the console can group
@roncodes
fix(network-orders): alias the orders query params so they cannot col…
bde3613 
…lide with the networks list's page, sort and query
@roncodes
feat(order-panel): the order details panel answers the dispatcher's f…
3a5e69c 
…ive questions first

- header: id, status and store/network badges, the next workflow action promoted to a button, Edit, the rest behind a menu
- Storefront::Order::FlowSteps renders the activity flow as steps (custom order configs contribute their own)
- Storefront::Order::IdentityStrip: customer, driver with inline assign, fulfillment and timing, total with tip and promotion
- tabs: Items (with store block and the other orders of the checkout), Route (with tracking), Payment, Activity (with comments), Customer, Data (metadata and documents); registered tabs still appended
- panel widened to 600px
@roncodes
feat(settings): one settings page with a section rail, labelled check…
10f3347 
…out rules and a save bar

- settings shell: store identity header with copy-store-key, a section rail (General, Branding and media, Locations, Checkout rules, Payment gateways, Notification channels, Alerts, API keys); anchors on the General page, routes for the rest
- General page restructured into always-open sections: general, branding and media, checkout rules, alerts
- every rule the server honours is a Storefront::SettingRule row with its consequence written under it, detail inputs appear when it is on
- sticky save bar with unsaved-change count and the sections touched; Discard rolls back attributes, options and alerts
@roncodes

roncodes commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

Superseded by the single overhaul PR (one branch, one PR targeting release/v0.4.25, per maintainer request).

@roncodes roncodes closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-docs Requires documentation updates needs-human-review Requires human review before proceeding type:feature Feature or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@roncodes