Repository navigation
fix(storefront): Create Customer Socket Token expects 404 while socket auth is off - #71
Merged
Merged
Conversation
…t auth is off Socket authentication is off by default and off in production until its rollout reaches it, so the documented answer is 404 and clients connect anonymously. The request asserts that unless the environment declares socket_auth_enabled, in which case it expects a token with its expiry.
roncodes
added a commit
to fleetbase/fleetbase
that referenced
this pull request
Oct 14, 2026
The contract stack should match production, where socket auth stays off until the #710 rollout reaches it. The socket-token endpoints answer 404 while it is off, and fleetbase/postman#71 asserts that unless the environment declares socket_auth_enabled. Reverts the switch from #717/#718.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Socket authentication is off by default and off in production until its rollout reaches it. While it is off
POST customers/socket-tokenanswers 404 and clients connect anonymously, which the request's description already documents. The request now asserts exactly that (expected_status404) unless the environment declaressocket_auth_enabled, in which case it expects a token withexpires_inandexpires_at.Pairs with a fleetbase/fleetbase PR that stops switching socket auth on in the contract stack, so the contract runs match production.