Repository navigation
fix(live-map): use the shipped map-marker.png as the driver/vehicle fallback icon - #371
Merged
Merged
Conversation
…d vehicles The Google live map fell back to /engines-dist/images/driver-marker.png and vehicle-marker.png, neither of which exists in assets/images, so a driver or vehicle without an avatar rendered a broken marker. Point both at the existing map-marker.png, as the leaflet live-fleet widget already does. The URLs stay literal strings so broccoli-asset-rev can fingerprint them in production.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 12379 12379
===========================================
Files 600 600
Lines 46496 46496
===========================================
Hits 46496 46496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
addon/components/map/google-live-map.jsfalls back to/engines-dist/images/driver-marker.png(drivers) and/engines-dist/images/vehicle-marker.png(vehicles) when a record has no avatar. Neither file exists inassets/images/or in the publishedfleetbase/fleetbase-console:v0.7.68image, so these markers render broken on the Google live map.Fix
Point both fallbacks at the existing
/engines-dist/images/map-marker.png. The leaflet live-fleet widget (addon/components/widget/live-fleet.hbs) already uses this file.Both URLs stay full literal strings, so broccoli-asset-rev rewrites them to the fingerprinted file names in production builds. It never rewrites interpolated paths (see #370).
Testing
No local build or test run. CI verifies the change.