Repository navigation
fix(mail): link customer credentials to /customer-access/{slug} - #354
Merged
Merged
Conversation
The customer portal resolves a company's access slug only under
/customer-access/{slug}; the credentials email linked /{slug}, which the
console does not route. Without a configured slug the link still points
at the portal's own /customer-portal sign-in.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomerCredentialsMailemailedUtils::consoleUrl($accessUrlSlug), which produceshttps://<console>/{slug}. The customer portal only resolves a company's access slug at/customer-access/{slug}: itsapplication:before-modelhook matches that path, and the admin settings URL field displays it. So the link in the credentials email led to an unrouted console page.The link is now
/customer-access/{slug}. If the company has no slug configured, it still falls back to/customer-portal, the engine's mount path and the portal's sign-in.Related: fleetbase/customer-portal#22 (settings authorization, account scoping and slug-collision fixes in the portal itself).
Tests
https://console.fleetbase.test/customer-access/acme-portal./customer-portal.