Add location test to demo by A6GibKm · Pull Request #72 · flatpak/libportal

A6GibKm · 2022-01-12T14:14:45Z

There is a caveat to test this in the demo, it has to be installed for it to work.

GeorgesStavracas · 2022-01-12T14:22:34Z

+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="lat">


latitudeLabel

Neither this

GeorgesStavracas · 2022-01-12T14:22:44Z

+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="lon">


longitudeLabel

Neither this

GeorgesStavracas · 2022-01-12T14:23:33Z

      create_call_free (call);
    }
+  else
+    ensure_location_updated_connected (call->portal);


Suggested change

ensure_location_updated_connected (call->portal);

{

ensure_location_updated_connected (call->portal);

}

This apparently has not been resolved

GeorgesStavracas · 2022-01-12T14:24:35Z

+   {
+     ensure_update_monitor_connection (call->portal);
+     g_task_return_boolean (call->task, TRUE);
+   }


if (error) { g_task_return_error (call->task, error); } else { ensure_update_monitor_connection (call->portal); g_task_return_boolean (call->task, TRUE); }

Neither this one

smcv · 2022-01-12T14:26:41Z

If done too soon it won't work

In what way does it not work?

I'm cautious about this because delaying a D-Bus signal connection until after a successful method call often leads to this anti-pattern:

client: call GetThing()
server: reply GetThing() -> 23
server: emit ThingChanged(to: 42)
client: receive reply GetThing() -> 23
client: subscribe to ThingChanged
too late! client will never find out that Thing changed to 42

A6GibKm · 2022-01-12T14:27:47Z

If done too soon it won't work

In what way does it not work?

I'm cautious about this because delaying a D-Bus signal connection until after a successful method call often leads to this anti-pattern:
* client: call GetThing()

* server: reply GetThing() -> 23

* server: emit ThingChanged(to: 42)

* client: receive reply GetThing() -> 23

* client: subscribe to ThingChanged

* too late! client will never find out that Thing changed to 42

It does not work in the sense that LocationUpdated will never be emitted on the other side of the DBus.

A6GibKm · 2022-01-12T14:30:43Z

I am not convinced this is the solution, but before this changes the location portal would fail about 19/20 times, now it only fails about 1/8 of times.

A6GibKm · 2022-01-12T14:33:42Z

I am marking a draft for if someone has a better solution.

A6GibKm · 2022-01-12T15:17:36Z

I think ill close it, it does not work on my other machine. This issue is the weirdest condition race I have ever seen.

All I know this issue is in libportal side since, ASHPD works in a reliable way.way.

grulja · 2022-01-13T12:13:08Z

I believe this can be closed as #67 is closed now.

A6GibKm · 2022-01-13T12:17:02Z

I updated the MR so just to include the location portal test to the demo.

GeorgesStavracas · 2022-06-20T12:19:07Z

      create_call_free (call);
    }
+  else
+    ensure_location_updated_connected (call->portal);


This apparently has not been resolved

GeorgesStavracas · 2022-06-20T12:19:20Z

+   {
+     ensure_update_monitor_connection (call->portal);
+     g_task_return_boolean (call->task, TRUE);
+   }


Neither this one

GeorgesStavracas · 2022-06-20T12:19:49Z

+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="lon">


Neither this

GeorgesStavracas · 2022-06-20T12:19:57Z

+          </object>
+        </child>
+        <child>
+          <object class="GtkLabel" id="lat">


Neither this

See https://gitlab.gnome.org/GNOME/gi-docgen/-/merge_requests/201. Generated by https://gitlab.gnome.org/World/design/emblem/-/merge_requests/40. The icon used was portal-symbolic from the devkit, using colors #26A269 to #33D17A were taken from the source of the SVG.

GeorgesStavracas requested changes Jan 12, 2022

View reviewed changes

A6GibKm changed the title ~~Fixes location and updates signal emissions~~ WIP: Fixes location and updates signal emissions Jan 12, 2022

A6GibKm marked this pull request as draft January 12, 2022 14:32

A6GibKm changed the title ~~WIP: Fixes location and updates signal emissions~~ Add location test to demo Jan 13, 2022

A6GibKm marked this pull request as ready for review January 13, 2022 12:17

GeorgesStavracas requested changes Jun 20, 2022

View reviewed changes

docs: Add favicons

734524b

See https://gitlab.gnome.org/GNOME/gi-docgen/-/merge_requests/201. Generated by https://gitlab.gnome.org/World/design/emblem/-/merge_requests/40. The icon used was portal-symbolic from the devkit, using colors #26A269 to #33D17A were taken from the source of the SVG.

A6GibKm force-pushed the master branch from 74f58c7 to 734524b Compare January 11, 2024 19:04

Conversation

A6GibKm commented Jan 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smcv commented Jan 12, 2022

Uh oh!

A6GibKm commented Jan 12, 2022

Uh oh!

A6GibKm commented Jan 12, 2022

Uh oh!

A6GibKm commented Jan 12, 2022

Uh oh!

A6GibKm commented Jan 12, 2022

Uh oh!

grulja commented Jan 13, 2022

Uh oh!

A6GibKm commented Jan 13, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

A6GibKm commented Jan 12, 2022 •

edited

Loading