feat(alert): add detail_url to AlertItem - #80
Merged
Merged
Conversation
The console page address is now part of the alert schema so clients can pass it through instead of dropping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做了什么
AlertItem增加detail_url，中英文 OpenAPI 和生成的 SDK 一起更新。客户端按类型重新序列化时不会再丢掉服务端返回的告警详情页地址。怎么验证
用这份 SDK 编译
fduty后，告警的 json / toon 输出里应出现detail_url。服务端对应改动在 fc-event。