Device details page: agent order device tab

[romanivan-flamingo]

Description

Agent order device tab (sort by agentType)

Task

Agent Order Randomly Changes in Device Tab

Summary by CodeRabbit

• Bug Fixes
  • Improved agent ordering in the Devices view by sorting consistently alphabetically by agent type.
  • Added a stable tie-break when multiple agents share the same type, using agent tool identifier (when available), reducing unexpected reordering across refreshes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 01592842-c683-4523-ba72-9408e84b245e

📥 Commits

Reviewing files that changed from the base of the PR and between c1bdac6 and 6966013.

📒 Files selected for processing (1)

• openframe/services/openframe-frontend/src/app/(app)/devices/components/tabs/agents-tab.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• openframe/services/openframe-frontend/src/app/(app)/devices/components/tabs/agents-tab.tsx

---

📝 Walkthrough

Walkthrough

The devices agents tab now sorts the combined agent list by agentType, then by agentToolId when types match, using localeCompare for deterministic ordering.

Changes

Agents tab ordering

Layer / File(s)	Summary
Combined agent sorting openframe/services/openframe-frontend/src/app/(app)/devices/components/tabs/agents-tab.tsx	combinedAgents now sorts by agentType alphabetically with localeCompare, then by agentToolId as a tie-breaker with missing values treated as ''.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 I hopped through the list with a tidy little grin,
Sorting the agents from alpha to zen.
With a second small nudge when the types agree,
The order stays steady as steady can be.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is related to the main change and clearly points to agent ordering in the device tab.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hotfix/agent-order-device-tab

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@openframe/services/openframe-frontend/src/app/`(app)/devices/components/tabs/agents-tab.tsx:
- Around line 107-108: The sorting in agents-tab.tsx only uses agentType in the
combinedAgents.sort comparator, so equal types can still reorder based on API
response order. Update the combinedAgents construction to carry a stable
upstream identifier, then revise the sort logic in the agents-tab component to
compare agentType first and that stable id second, ensuring deterministic
ordering across reloads even when agentType matches.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5078d20a-b419-4208-b4fe-493c59723685

📥 Commits

Reviewing files that changed from the base of the PR and between 71a9e6d and c1bdac6.

📒 Files selected for processing (1)

• openframe/services/openframe-frontend/src/app/(app)/devices/components/tabs/agents-tab.tsx