chore: depreacte CIUtils.runTitle() method#20
Conversation
Turns out there's no good way to extract title from the CI.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a91a180dd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| */ | ||
| export function runTitle(): string | undefined { | ||
| return githubActionsTitle(); | ||
| return undefined; |
There was a problem hiding this comment.
Returning undefined unconditionally here is a silent behavioral break for existing callers of CIUtils.runTitle(): in GitHub Actions jobs where GITHUB_WORKFLOW is set, reports that previously got a meaningful title will now lose it unless every consumer is migrated immediately to set title manually. Because the function type is unchanged (string | undefined), this regression is easy to miss in downstream code, so deprecating the API should preserve the prior fallback behavior until removal.
Useful? React with 👍 / 👎.
1 participant
Turns out there's no good way to extract title from the CI.