Skip to content

devops: externalize peer dependencies #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aslushnikov merged 1 commit into from
Mar 22, 2026
Merged

devops: externalize peer dependencies #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const { errors } = await esbuild.build({
// Bundle, but keep un-bundled all public dependencies.
external: Object.keys({
...pkg.dependencies,
...pkg.peerDependencies,

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't make flakiness-report a new runtime dependency

For consumers that currently install only @flakiness/sdk (or receive it transitively), this line turns @flakiness/flakiness-report into a new runtime requirement. src/reportUtils.ts:3-4 pulls normalizeReport and validateReport into the published entry bundles, and those modules use runtime symbols from the peer package (src/normalizeReport.ts:72, src/validateReport.ts:11), so lib/index.js/lib/browser.js will now ship bare @flakiness/flakiness-report imports instead of bundled code. Updating to this release would therefore start failing with module-resolution errors unless the host explicitly adds the peer, which is a breaking change rather than an internal build tweak.

Useful? React with 👍 / 👎.

@aslushnikov aslushnikov Mar 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this works as expected

}),
minify: false,
});
Expand Down