Repository navigation
Hours batch edit improvements - #232
Open
JorgeUrgiles wants to merge 6 commits into
Open
JorgeUrgiles wants to merge 6 commits into
JorgeUrgiles wants to merge 6 commits into
Conversation
flack
reviewed
Oct 19, 2026
flack
reviewed
Oct 19, 2026
Owner
|
One thing that's a bit confusing: You can now select a value for a field and click the clear all checkbox at the same time. Ideally I think the checkbox should only be shown if the placeholder is shown, or otherwise clicking the checkbox should remove a selected value 
|
…e unused autocomplete
flack
reviewed
Oct 19, 2026
flack
reviewed
Oct 19, 2026
| if (selection.length) { | ||
| empty = selection.val() === '[]'; | ||
| } else if (editor) { | ||
| empty = editor.CodeMirror.getValue() === ''; |
Owner
There was a problem hiding this comment.
could we somehow check the underlying textarea instead? Would make it more flexible to work with e.g. tinymce also
flack
reviewed
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.