add_fivetran_deleted_column_and_filter#9
Merged
fivetran-savage merged 4 commits intoOct 21, 2025
Conversation
fivetran-joemarkiewicz
requested changes
Oct 21, 2025
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
Collaborator
There was a problem hiding this comment.
@fivetran-savage great work on this PR! Some small changes before approval. Be sure to regen the docs after making these updates and marking as ready for re-review. Thanks!
| cast(parent_asin as {{ dbt.type_string() }}) as parent_asin, | ||
| upper(type) as type | ||
| from fields | ||
| where coalesce(_fivetran_deleted, false) = false |
Collaborator
There was a problem hiding this comment.
When writing these types of queries the standard is to use the following approach (see here as an example).
Suggested change
| where coalesce(_fivetran_deleted, false) = false | |
| where not coalesce(_fivetran_deleted, false) |
| [PR #9](https://github.com/fivetran/dbt_amazon_selling_partner/pull/9) includes the following updates: | ||
|
|
||
| ## Under the Hood | ||
| - Added `_fivetran_deleted` filter to `stg_amazon_selling_partner__item_relationship` model to exclude soft-deleted records and improve data quality. |
Collaborator
There was a problem hiding this comment.
Let's also include in this same bullet that this update was made to correspond with the same update being applied to the upstream connector. We can then link the release notes.
Corrected the spelling of 'inbound_shipped_quantity' to 'inblound_shipped_quantity'.
fivetran-savage
deleted the
feature/add_fivetran_deleted_column_and_filter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog