Fix "inblound" typo and adjust seed configs#12
Merged
Conversation
|
|
||
| | Data Model(s) | Change type | Old | New | Notes | | ||
| | ------------- | ----------- | ----| --- | ----- | | ||
| | `amazon_selling_partner__item_inventory`<br>`stg_amazon_selling_partner__fba_inventory_summary` | Column rename | `inblound_shipped_quantity` | `inbound_shipped_quantity` | The typo column `inblound_shipped_quantity` will be retained until March 2026 for backwards compatibility, after which it will be officially sunset in favor of `inbound_shipped_quantity`. | |
Contributor
There was a problem hiding this comment.
I think we should call it out on perhaps two lines like this so it's obvious both columns will exist for a bit.
Suggested change
| | `amazon_selling_partner__item_inventory`<br>`stg_amazon_selling_partner__fba_inventory_summary` | Column rename | `inblound_shipped_quantity` | `inbound_shipped_quantity` | The typo column `inblound_shipped_quantity` will be retained until March 2026 for backwards compatibility, after which it will be officially sunset in favor of `inbound_shipped_quantity`. | | |
| | `amazon_selling_partner__item_inventory`<br>`stg_amazon_selling_partner__fba_inventory_summary` | New Column | | `inbound_shipped_quantity` | Fixes the spelling of the `inblound_shipped_quantity` column. | | |
| | `amazon_selling_partner__item_inventory`<br>`stg_amazon_selling_partner__fba_inventory_summary` | Deprecated Column | `inblound_shipped_quantity` | | The typo column `inblound_shipped_quantity` will be retained until March 2026 for backwards compatibility, after which it will be officially sunset in favor of `inbound_shipped_quantity`. | |
Contributor
Author
There was a problem hiding this comment.
Sounds good, added directly!
| | `amazon_selling_partner__item_inventory`<br>`stg_amazon_selling_partner__fba_inventory_summary` | Column rename | `inblound_shipped_quantity` | `inbound_shipped_quantity` | The typo column `inblound_shipped_quantity` will be retained until March 2026 for backwards compatibility, after which it will be officially sunset in favor of `inbound_shipped_quantity`. | | ||
|
|
||
| ## Under the Hood | ||
| - Removes unused seed files. |
Contributor
There was a problem hiding this comment.
I would add that we added the indentifiers.
| description: '{{ doc("inbound_shipped_quantity") }}' | ||
| - name: inblound_shipped_quantity | ||
| description: '{{ doc("inblound_shipped_quantity") }}' | ||
| description: Typo version of `inbound_shipped_quantity` kept for backward compatibility. Will be removed in March 2026 |
Contributor
There was a problem hiding this comment.
I would add the deprecated label.
Suggested change
| description: Typo version of `inbound_shipped_quantity` kept for backward compatibility. Will be removed in March 2026 | |
| description: [DEPRECATED] Typo version of `inbound_shipped_quantity` kept for backward compatibility. Will be removed in March 2026 |
Contributor
Author
There was a problem hiding this comment.
addressed directly
| description: "{{ doc('fc_processing_quantity') }}" | ||
| - name: inblound_shipped_quantity | ||
| description: "{{ doc('inblound_shipped_quantity') }}" | ||
| description: Typo version of `inbound_shipped_quantity` kept for backward compatibility. Will be removed in March 2026 |
Contributor
There was a problem hiding this comment.
I would add a deprecated callout.
Suggested change
| description: Typo version of `inbound_shipped_quantity` kept for backward compatibility. Will be removed in March 2026 | |
| description: [DEPRECATED] Typo version of `inbound_shipped_quantity` kept for backward compatibility. Will be removed in March 2026 |
Contributor
Author
There was a problem hiding this comment.
addressed directly
| @@ -14,7 +14,7 @@ | |||
| {"name": "fullfillable_quantity", "datatype": dbt.type_int()}, | |||
Contributor
There was a problem hiding this comment.
I think is another typo we should fix. It should be 'fulfillable_quantity' with 3 Ls instead of 4.
Contributor
Author
There was a problem hiding this comment.
Ah great catch, updating!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
inblound_shipped_quantityin favor ofinbound_shipped_quantitySubmission Checklist
Changelog