Fce 1631 Run type checking against TS code snippets#131
Merged
Conversation
PiotrWodecki
force-pushed
the
FCE-1631-typecheck-snippets
branch
from
57e6ae3 to
6327d24
Compare
PiotrWodecki
force-pushed
the
FCE-1631-typecheck-snippets
branch
from
ecad488 to
6ed1cea
Compare
PiotrWodecki
force-pushed
the
FCE-1631-typecheck-snippets
branch
from
6ed1cea to
4f1404e
Compare
PiotrWodecki
force-pushed
the
FCE-1631-typecheck-snippets
branch
from
e17851e to
96dcf01
Compare
PiotrWodecki
force-pushed
the
FCE-1631-typecheck-snippets
branch
from
b292d3a to
3f1ad87
Compare
PiotrWodecki
added a commit
to fishjam-cloud/web-client-sdk
that referenced
this pull request
Jul 3, 2025
## Description This PR is required to make the repo compatible with the changes in fishjam-cloud/documentation#131 ## Motivation and Context - added an import to a jsdoc - bumps yarn to get rid of flip-flopping ts version yarnpkg/berry#6189 ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
MiloszFilimowski
approved these changes
Jul 3, 2025
MiloszFilimowski
left a comment
MiloszFilimowski
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, just some minor comments
czerwiukk
reviewed
Jul 3, 2025
czerwiukk
reviewed
Jul 4, 2025
czerwiukk
approved these changes
Jul 4, 2025
Co-authored-by: adrian <33912477+czerwiukk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.