[codex] Align create model guide with API#81
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
📝 WalkthroughWalkthroughThis PR refreshes documentation for voice model creation across the API reference and developer guide. It updates the Create Model endpoint reference with clarified multipart/form-data guidance, replaces SDK code examples with current FishAudio client patterns, modernizes REST API examples, refines model settings tables, and expands troubleshooting and best-practices sections. ChangesVoice Model Creation Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
developer-guide/core-features/creating-models.mdx (1)
19-53: ⚡ Quick winAdd a short prerequisites block before procedural steps.
This guide now has multiple executable flows, but it doesn’t list prerequisites up front (API key, SDK install/runtime, sample audio files). Adding that near the first procedure will reduce setup friction and support failures.
As per coding guidelines, "Include prerequisites at the start of procedural content".
Also applies to: 113-123
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@developer-guide/core-features/creating-models.mdx` around lines 19 - 53, Add a short "Prerequisites" block and insert it before the first procedural section (i.e., before the <Steps> block under "Web Interface") and likewise before other procedural flows such as the "Using the API" / "Using the SDK" sections; this block should list required items like an account and API key, required SDK/runtime versions (e.g., pip/npm install steps), minimum sample audio requirements (number of files and minimum duration per file), and any environment or permission requirements so readers can complete the subsequent <Step> and code examples without unknown preconditions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@developer-guide/core-features/creating-models.mdx`:
- Around line 19-53: Add a short "Prerequisites" block and insert it before the
first procedural section (i.e., before the <Steps> block under "Web Interface")
and likewise before other procedural flows such as the "Using the API" / "Using
the SDK" sections; this block should list required items like an account and API
key, required SDK/runtime versions (e.g., pip/npm install steps), minimum sample
audio requirements (number of files and minimum duration per file), and any
environment or permission requirements so readers can complete the subsequent
<Step> and code examples without unknown preconditions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 90c832db-d44a-4756-b42f-ce5e77a16dae
📒 Files selected for processing (2)
api-reference/endpoint/model/create-model.mdxdeveloper-guide/core-features/creating-models.mdx
What changed
FishAudio().voices.create(...).type=ttsandtrain_mode=fast, and the REST_idresponse field.voice.id, while REST and JavaScript examples use_id.enhance_audio_qualitydefaulttrueand addedgenerate_sample.reference_id.Why
The guide mixed older SDK usage and stale field names with the current Create Model API. This made the docs disagree with the OpenAPI schema and could lead users to send invalid requests or read the wrong response field.
Validation
./node_modules/.bin/prettier --check developer-guide/core-features/creating-models.mdx api-reference/endpoint/model/create-model.mdxnpm run check:openapiNote:
mint validatewas also attempted and reached repository-wide pre-existing warnings in snippets/temp files unrelated to this change.Summary by CodeRabbit