Restore Anonymize All button on overview by default

[levoncrypto]

No description provided.

[codeant-ai]

User narek@nareks-macbook-pro.local does not have a PR Review subscription.

Go to Team management and add this email to the PR Review subscription.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2aa0b48e-0659-43db-8579-d06297067410

📥 Commits

Reviewing files that changed from the base of the PR and between fe2905a and 85cdc13.

📒 Files selected for processing (1)

• src/qt/optionsmodel.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• src/qt/optionsmodel.cpp

---

Summary by CodeRabbit

• Bug Fixes
  • Changed the default for a privacy-related setting so it is enabled when missing, ensuring consistent initialization and expected behavior for users.

Walkthrough

OptionsModel::Init now initializes missing fSparkPage to true and reads it with true as the fallback default instead of previously inheriting or defaulting to false.

Changes

Spark page settings initialization

Layer / File(s)	Summary
Spark page default initialization src/qt/optionsmodel.cpp	When fSparkPage is absent in QSettings, it is written as true and later read using true as the default fallback.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title refers to restoring an 'Anonymize All button,' but the actual change modifies the default value of fSparkPage setting, which appears unrelated to button restoration.	Clarify the title to accurately reflect the actual change (e.g., 'Set fSparkPage default to true' or explain the connection between the setting and the button).
Description check	⚠️ Warning	No pull request description was provided, but the template requires a mandatory 'PR intention' section explaining what the PR does and what issue it solves.	Add a description following the template with 'PR intention' explaining how the fSparkPage setting change relates to restoring the Anonymize All button.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch anonymize_button_fix

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Infer (1.2.0)

src/qt/optionsmodel.cpp

In file included from src/qt/optionsmodel.cpp:9:
src/qt/optionsmodel.h:8:10: fatal error: 'amount.h' file not found
8 | #include "amount.h"
| ^~~~~~~~~~
1 error generated.
Error: the following clang command did not run successfully:
/opt/infer-linux-x86_64-v1.2.0/lib/infer/facebook-clang-plugins/clang/install/bin/clang-18
@/tmp/coderabbit-infer/85cdc13defa8df002e99281cd9030884ccf1c306-4c07ece488f7cddf/tmp/clang_command_.tmp.615c46.txt
++Contents of '/tmp/coderabbit-infer/85cdc13defa8df002e99281cd9030884ccf1c306-4c07ece488f7cddf/tmp/clang_command_.tmp.615c46.txt':
"-cc1" "-load"
"/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../../facebook-clang-plugins/libtooling/build/FacebookClangPlugin.dylib"
"-add-plugin" "BiniouASTExporter" "-plugin-arg-BiniouASTExporter" "-"
"-plugin-arg-BiniouASTExporter" "PREPEND_CURRENT_DIR=1"
"-plugin-arg-BiniouASTExporter" "MAX_STRING_SIZE=65535" "-cc1" "-triple"
"x86_64-unknown-linux-gnu" "-emit-obj"

... [truncated 1095 characters] ...

ang/install/lib/clang/18/include"
"-internal-isystem" "/usr/local/include" "-internal-isystem"
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include"
"-internal-externc-isystem" "/usr/include/x86_64-linux-gnu"
"-internal-externc-isystem" "/include" "-internal-externc-isystem"
"/usr/include" "-Wno-ignored-optimization-argument" "-Wno-everything"
"-fdeprecated-macro" "-ferror-limit" "19" "-fgnuc-version=4.2.1"
"-fskip-odr-check-in-gmf" "-fcxx-exceptions" "-fexceptions"
"-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o"
"/tmp/coderabbit-infer/4c07ece488f7cddf/file.o" "-x" "c++"
"src/qt/optionsmodel.cpp" "-O0" "-fno-builtin" "-include"
"/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../lib/clang_wrappers/global_defines.h"
"-Wno-everything"

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c85129bce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Preserve explicit Spark-page opt-outs

When upgrading an existing profile that has fSparkPage=false, this migration always rewrites it to true before setting the one-time marker. Since fSparkPage is also the persisted value written by the options dialog when a user disables “Enable Spark manual-anonymize page”, users who intentionally hid the overview Anonymize All controls will have them re-enabled on the first startup after this change rather than only changing the default for unset profiles.

Useful? React with 👍 / 👎.