Net: clear Tor reply state on disconnect#1843
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Reuben Yap <reuben@firo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR intention
Prevent stale Tor control reply callbacks from surviving a control socket disconnect and consuming replies from a later reconnection. Without this cleanup, a Tor restart or control socket drop after queued GETINFO/ADD_ONION commands can leave the controller connected but unauthenticated, with the onion service removed and never restored until process restart.
Code changes brief
Clear the in-progress Tor reply and queued reply handlers whenever
TorControlConnection::Disconnect()tears down the bufferevent, so each new control connection starts with an empty reply pipeline.