CI: use macos-latest for release build

[levoncrypto]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@levoncrypto has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 12 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 12 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e805a3b-e93c-48ad-bfee-2f5b0779fa49

📥 Commits

Reviewing files that changed from the base of the PR and between 071b0fe and 39f3742.

📒 Files selected for processing (1)

• contrib/dash/actions/script-osx.sh

Walkthrough

Updated the macOS build job runner in CI from a pinned image to the floating latest image; made gettext PATH setup conditional in the macOS build script to use Homebrew when present; appended -liconv to LIBS on macOS in the zbar build script to resolve iconv linker symbols.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow .github/workflows/build_release.yml	Changed build_osx job runs-on from macos-13 to macos-latest. No other workflow logic changed.
macOS Build Script contrib/dash/actions/script-osx.sh	Make gettext PATH setup conditional: if brew exists, prepend $(brew --prefix gettext)/bin to PATH; otherwise keep the previous /usr/local/opt/gettext/bin fallback.
zbar macOS build tweak contrib/make_zbar.sh	On Darwin, append -liconv to LIBS before running ./configure to address iconv linker symbol resolution (arm64 note).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Update Github Actions to macos-12 #56: Modified the same GitHub Actions workflow (.github/workflows/build_release.yml) affecting the macOS runner configuration.
• Update Github Actions workflow to use macOS 13 #74: Also modified the workflow file’s macOS runner version for the build_osx job.

Suggested reviewers

• levonpetrosyan93

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate whether it is related to the changeset.	Add a pull request description explaining the changes and their rationale, even if brief.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'CI: use macos-latest for release build' accurately reflects the primary change in the changeset, which updates the macOS build job runner to use the latest image.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch update-actions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

contrib/dash/actions/script-osx.sh (1)

31-36: Address shellcheck warning: declare and assign separately to avoid masking return values.

The export PATH="$(brew --prefix gettext)/bin:$PATH" pattern masks the exit code of brew --prefix gettext. If gettext isn't installed via Homebrew, this fails silently and adds an invalid path.

♻️ Proposed fix to separate declaration and assignment

 if command -v brew >/dev/null 2>&1; then
-  export PATH="$(brew --prefix gettext)/bin:$PATH"
+  GETTEXT_PREFIX="$(brew --prefix gettext)"
+  export PATH="${GETTEXT_PREFIX}/bin:$PATH"
 else
   export PATH="/usr/local/opt/gettext/bin:$PATH"
 fi

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contrib/dash/actions/script-osx.sh` around lines 31 - 36, The export
currently masks brew's exit code; change to first capture brew's prefix into a
variable (e.g., gettext_prefix=$(brew --prefix gettext 2>/dev/null)), check its
success/that the directory exists, and only then export
PATH="$gettext_prefix/bin:$PATH"; if that check fails fall back to exporting
PATH="/usr/local/opt/gettext/bin:$PATH". Keep the existing command -v brew check
and use the captured gettext_prefix when updating PATH so brew's failure isn't
silently masked.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@contrib/dash/actions/script-osx.sh`:
- Around line 31-36: The export currently masks brew's exit code; change to
first capture brew's prefix into a variable (e.g., gettext_prefix=$(brew
--prefix gettext 2>/dev/null)), check its success/that the directory exists, and
only then export PATH="$gettext_prefix/bin:$PATH"; if that check fails fall back
to exporting PATH="/usr/local/opt/gettext/bin:$PATH". Keep the existing command
-v brew check and use the captured gettext_prefix when updating PATH so brew's
failure isn't silently masked.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ddc3a711-5e9e-4f60-bd7f-1bdafcf427ae

📥 Commits

Reviewing files that changed from the base of the PR and between 3f10d72 and d271cc3.

📒 Files selected for processing (2)

• .github/workflows/build_release.yml
• contrib/dash/actions/script-osx.sh