Skip to content

fix: add snapshot store, health indicators, and metrics#10

Merged
casc84ab merged 2 commits into
developfrom
fix/framework-hardening
Feb 13, 2026
Merged

fix: add snapshot store, health indicators, and metrics#10
casc84ab merged 2 commits into
developfrom
fix/framework-hardening

Conversation

@ancongui

Copy link
Copy Markdown
Contributor

Summary

  • Implement R2dbcSnapshotStore with configurable retention
  • Wire SnapshotAutoConfiguration with actual bean definitions
  • Implement EventStoreHealthIndicator, OutboxHealthIndicator
  • Wire EventSourcingMetricsConfiguration with Micrometer
  • Implement metadata query in R2dbcEventStore (replace Flux.empty stub)
  • Fix event publishing error handling (replace silent .onErrorContinue)
  • Fix property prefix to firefly.eventsourcing.outbox.processor
  • Add snapshot migration SQL

Test plan

  • All existing tests pass
  • New tests added for new functionality
  • Manual verification of key flows

…ntscan and @import removal

Part of the Firefly Framework hexagonal architecture remediation.

- Remove @componentscan from EventSourcingAutoConfiguration
- Add 6 explicit @bean @ConditionalOnMissingBean methods
- Remove @Component/@service from 6 component classes
- Remove @import (bypasses conditional guards)
- Add EventStoreAutoConfiguration, SnapshotAutoConfiguration,
  EventSourcingHealthConfiguration, EventSourcingMetricsConfiguration
  to .imports file
…ta query

- Implement R2dbcSnapshotStore with configurable retention
- Wire SnapshotAutoConfiguration with actual bean definitions
- Implement EventStoreHealthIndicator, OutboxHealthIndicator
- Wire EventSourcingMetricsConfiguration with Micrometer
- Implement metadata query in R2dbcEventStore (replace Flux.empty stub)
- Fix event publishing error handling (replace silent .onErrorContinue)
- Fix property prefix to firefly.eventsourcing.outbox.processor
- Add snapshot migration SQL
@ancongui ancongui requested a review from casc84ab February 13, 2026 00:34

@casc84ab casc84ab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - R2dbcSnapshotStore with configurable retention, health indicators (EventStore, Outbox, Snapshot, Projection), Micrometer metrics wiring, metadata query implementation. Replaces stubs with real implementations.

@casc84ab casc84ab merged commit c78a7ce into develop Feb 13, 2026
4 checks passed
@casc84ab casc84ab deleted the fix/framework-hardening branch February 13, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants