[SH] Rebase against main#5836
Merged
JackThomson2 merged 0 commit intoJun 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5836 +/- ##
======================================================
Coverage 81.25% 81.25%
======================================================
Files 279 279
Lines 31226 31226
======================================================
Hits 25373 25373
Misses 5853 5853
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JackThomson2
force-pushed
the
sh/rebase-14-04
branch
from
ad8ea1a to
f6dcaac
Compare
zulinx86
previously approved these changes
Apr 20, 2026
JackThomson2
force-pushed
the
sh/rebase-14-04
branch
2 times, most recently
from
b7b5bff to
276f4a9
Compare
JackThomson2
force-pushed
the
sh/rebase-14-04
branch
2 times, most recently
from
21ca379 to
334a264
Compare
JackThomson2
merged commit 334a264
into
firecracker-microvm:feature/secret-hiding
2 of 5 checks passed
JackThomson2
force-pushed
the
feature/secret-hiding
branch
from
3599d3b to
334a264
Compare
Contributor
Author
|
Incase of issue backup of the original branch still present here: https://github.com/JackThomson2/firecracker/tree/backup/feature-secret-hiding-pre-rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing the secret hiding branch against main
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.Add two new CPU templates for Granite Rapids: