🫐 [just] gh-process v7.0 fixes many bugs#41
Merged
Conversation
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository’s just-based GitHub PR/repo-metadata automation to address formatting/metadata sync edge cases and add a regression test harness for the updated sync logic.
Changes:
- Trim trailing blank lines from generated PR-body footer content to prevent round-trip accumulation.
- Make
.repo.tomlGitHub-metadata sync more robust (handles missing/commented keys inside[about], restores backups on verification failure). - Add a bash test runner intended to validate the updated awk-based
[about]rewrite behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .just/lib/update_pr_body.sh | Trims trailing blank lines from the footer section before emitting the updated PR body. |
| .just/lib/cue_sync_test.sh | Adds a bash test harness for the cue-sync-from-github awk transformation logic. |
| .just/gh-process.just | Bumps the PR create comment/version marker to v7.0. |
| .just/cue-verify.just | Reworks awk logic for [about] updates and strengthens backup/verification behavior around .repo.toml sync. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+120
| local workspace | ||
| workspace=$(mktemp -d) | ||
| cp "$fixture_path" "$workspace/.repo.toml" |
Comment on lines
+156
to
+160
| if [[ ! -d "$REPO_ROOT/$FIXTURES_DIR" ]]; then | ||
| echo -e "${YELLOW}No test fixtures found at $FIXTURES_DIR${NORMAL}" | ||
| echo "Tests skipped" | ||
| return 0 | ||
| fi |
Comment on lines
+75
to
+78
| key_line=$(grep -nE "$key_pat" "$output" | head -1 | cut -d: -f1 || true) | ||
| # Find the next non-[about] section header. grep -n emits "N:content"; | ||
| # filter on the content after the colon so [about] itself is excluded. | ||
| section_line=$(grep -nE '^\[' "$output" | grep -v '^[0-9]*:\[about\]' | head -1 | cut -d: -f1 || true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Meta
(Automated in
.just/gh-process.just.)