🌂 [gha] unpin slsa-github-generator since pinning broke it#305
Merged
Conversation
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release provenance generation setup to use the SLSA GitHub Generator by tag ref (instead of a commit SHA), because the generator’s internal checkout logic fails when invoked from a SHA-pinned reusable workflow. It also adjusts the zizmor configuration to permit this exception.
Changes:
- Switch
slsa-framework/slsa-github-generatorreusable workflow invocation from a pinned SHA to@v2.1.0. - Add inline documentation in the workflow explaining the “Invalid ref” failure mode when SHA-pinned.
- Update
.github/zizmor.ymlpolicy to allow non-SHA refs forslsa-framework/slsa-github-generator.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/zizmor.yml |
Allows slsa-framework/slsa-github-generator to be referenced by ref (to accommodate tag usage). |
.github/workflows/release.yml |
Uses the SLSA generator reusable workflow via @v2.1.0 tag and documents why SHA pinning breaks provenance generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Meta
(Automated in
.just/gh-process.just.)