Feature: Cross-fade#1625
Open
medallyon wants to merge 1 commit into
Open
Conversation
Member
|
Hey @medallyon, thanks for whipping up this PR! I haven't tested this yet and only skimmed the code, but maybe this pointer help you to finish this up? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
My attempt at adding an optional cross-fade feature to finamp. Adds a setting to Settings > Audio Service in the form of a slider, representing the number of seconds that tracks in a playlist should cross-fade into each other.
Todo before merging
If you have any clue how to avoid the tiny gap that appears when the crossfade starts, feel free to spit out some ideas. I've tried buffering the secondary instance a little earlier but that doesn't seem to fix it.
Related Issues
Should address #237 if we can work out the final kinks.
Also needs more thorough testing on real devices.