Skip to content

Feature: Cross-fade#1625

Open
medallyon wants to merge 1 commit into
finamp-app:redesignfrom
medallyon:cross-fade
Open

Feature: Cross-fade#1625
medallyon wants to merge 1 commit into
finamp-app:redesignfrom
medallyon:cross-fade

Conversation

@medallyon

Copy link
Copy Markdown

Changes

My attempt at adding an optional cross-fade feature to finamp. Adds a setting to Settings > Audio Service in the form of a slider, representing the number of seconds that tracks in a playlist should cross-fade into each other.

Todo before merging

If you have any clue how to avoid the tiny gap that appears when the crossfade starts, feel free to spit out some ideas. I've tried buffering the secondary instance a little earlier but that doesn't seem to fix it.

  • Translations
  • Reset Settings
  • Extended CONTRIBUTING.md

Related Issues

Should address #237 if we can work out the final kinks.

Also needs more thorough testing on real devices.

@Chaphasilor

Copy link
Copy Markdown
Member

Hey @medallyon, thanks for whipping up this PR!
I think the architecture with the outgoing crossfade player and skipping main player is a neat idea and should keep things reliable, if we can get rid of the gap.
About that: maybe try setting useLazyPreparation to false when initiating the crossfade AudioPlayer? That should cause it to start loading up the audio sources immediately, afaik.

I haven't tested this yet and only skimmed the code, but maybe this pointer help you to finish this up? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants